Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-storybook (v3) doesn't work anymore #1203

Closed
dangreen opened this issue Jun 6, 2017 · 12 comments
Closed

build-storybook (v3) doesn't work anymore #1203

dangreen opened this issue Jun 6, 2017 · 12 comments

Comments

@dangreen
Copy link

dangreen commented Jun 6, 2017

In my configuration i inject some loaders into module.rules, it perfectly works with start-storybook. build-storybook v2 also works perfectly: it compile and copy all assets into build dir.
With v3: it doesn't copy assets anymore.

Also in browser i have this issue (node-sass? wtf??):

Uncaught Error: Module build failed: Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (57)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.5.2
    at module.exports (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/node-sass/lib/binding.js:13:13)
    at Object.<anonymous> (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:569:30)
    at Module._extensions..js (module.js:580:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/babel-register/lib/node.js:152:7)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at module.exports (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/node-sass/lib/binding.js:13:13)
    at Object.<anonymous> (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:569:30)
    at Module._extensions..js (module.js:580:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/dangreen/github/leadcooker2/new-frontend/node_modules/babel-register/lib/node.js:152:7)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.freeExports (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:73155:7)
    at __webpack_require__ (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:20:30)
    at Object.<anonymous> (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:80504:15)
    at __webpack_require__ (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:20:30)
    at Object.<anonymous> (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:64909:73)
    at Object.defineProperty.value (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:64938:30)
    at __webpack_require__ (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:20:30)
    at Object.<anonymous> (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:80939:18)
    at __webpack_require__ (http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:20:30)
    at http://develop.trigen.pro/leadcooker-ui/static/preview.1a904cf1fa11c8c72bc5.bundle.js:66:18
@ndelangen ndelangen changed the title build-stroybook (v3) doesn't work anymore build-storybook (v3) doesn't work anymore Jun 6, 2017
@ndelangen
Copy link
Member

What loaders are you injecting?

@dangreen
Copy link
Author

dangreen commented Jun 6, 2017

@ndelangen

[{
	test: /\.scss$/,
	use: [{
		loader: 'style-loader'
	}, {
		loader:  'css-loader',
		options: {
			importLoaders: 1
		}
	}, {
		loader: 'postcss-loader',
		options: {
			plugins: () => [
				autoprefixer(autoprefixerConfig)
			]
		}
	}, {
		loader:  'resolve-url-loader',
		options: {
			sourceMap: true,
			keepQuery: true
		}
	}, {
		loader:  'sass-loader',
		options: {
			sourceMap: true
		}
	}]
}, {
	test: /\.svg$/,
	use:  [{
		loader:  'svg-sprite-loader',
		options: {
			runtimeGenerator: path.join(cwd, 'tasks/helpers/svg-to-component.js'),
			runtimeOptions:   {
				iconModule: path.join(cwd, paths.src.app, 'ui/components/icon/icon.js')
			}
		}
	}]
}, {
	test:   /\.(eot|woff|ttf)$/,
	loader: 'file-loader'
}]

@danielduan
Copy link
Member

Node 8 is the unsupported runtime. Looks like they support only up to 7.
https://github.com/sass/node-sass/releases/tag/v4.5.2

@ndelangen
Copy link
Member

It's possible got get working. Can you confirm it does work in node < 8 ?

@dangreen
Copy link
Author

dangreen commented Jun 7, 2017

@ndelangen with node v7 all works.

@ndelangen
Copy link
Member

I'm not sure what to do, I'm not faced with this error on my machine, and I'm running Node 8.0.3.
node-sass should support node 8 now: sass/node-sass#1985

@danielduan
Copy link
Member

@dangreen try upgrading the sass-loader and node-sass to the latest and see if that at least fixes the sass problem for you?

@dangreen
Copy link
Author

dangreen commented Jun 8, 2017

@danielduan i'm already on latest version of sass-loader

@ndelangen
Copy link
Member

Do you have a repository we can use to reproduce the issue?

@BerndWessels
Copy link

Maybe related to this issue.

@alloy
Copy link

alloy commented Jun 29, 2017

I think we’re having the same issue as OP, here’s a repo to reproduce with: https://github.com/artsy/reaction-force. The build task appears to succeed (see deployment step), but no JS files are output.

@danielduan
Copy link
Member

If this is still an issue on the latest versions, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants