New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StorybookUI: Opening canvas in new tab should maintain custom properties (such as the background set for the canvas) #12430
Comments
I think we can (should?) do this for |
Thanks guys for looking into this, really appreciated! |
@iugabogdan -- I wonder why you wouldn't create a hardcoded story for the given |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Possibly fixed by #13803 |
Yes, thanks a lot guys! Much appreciated! <3 |
Describe the bug
Opening a canvas in new tab should maintain all the previous properties set on the canvas.
I am not sure if this is a bug or should be a feature. However I expect that if I set a particular background on the canvas, I expect to see it also in the new tab, because I want to see the canvas I edited before, right ?
Also, is there a way to override that background ? Or like providing some parameters ? like knobs. If yes then it would be perfect.
To Reproduce
Expected behavior
The canvas opened in new tab should have the background colour I have set in the story
Screenshots
How the canvas looks before I open it in new tab:
How it looks after it is opened in new tab:
System:
Environment Info:
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
Node: 12.10.0 - ~/.nvm/versions/node/v12.10.0/bin/node
Yarn: 1.17.3 - ~/.nvm/versions/node/v12.10.0/bin/yarn
npm: 6.14.7 - ~/.nvm/versions/node/v12.10.0/bin/npm
Browsers:
Chrome: 84.0.4147.89
Safari: 13.1.2
The text was updated successfully, but these errors were encountered: