Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-docs] Centered layout not working in Docs #12935

Closed
jbanulso opened this issue Oct 28, 2020 · 7 comments
Closed

[addon-docs] Centered layout not working in Docs #12935

jbanulso opened this issue Oct 28, 2020 · 7 comments
Assignees
Labels

Comments

@jbanulso
Copy link

jbanulso commented Oct 28, 2020

Describe the bug
Stories are not centered in Docs when using layout: 'centered' in the global parameters. This used to work before 6.1, but not anymore.

To Reproduce
Have a preview file with at least this:

export const parameters = {
  layout: 'centered'
};

Expected behavior
Stories should be centered in Docs as well as in Canvas.

System
Package.json:

"@storybook/addon-a11y": "^6.1.0-alpha.31",
"@storybook/addon-essentials": "^6.1.0-alpha.31",
"@storybook/addon-knobs": "^6.1.0-alpha.31",
"@storybook/addons": "^6.1.0-alpha.31",
"@storybook/react": "^6.1.0-alpha.31",
"@storybook/theming": "^6.1.0-alpha.31",

System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Binaries:
Node: 12.16.1 - /usr/local/bin/node
Yarn: 1.22.5 - /usr/local/bin/yarn
npm: 6.13.4 - /usr/local/bin/npm
Browsers:
Chrome: 86.0.4240.111
Firefox: 81.0.2
Safari: 14.0

@shilman
Copy link
Member

shilman commented Oct 28, 2020

@jbanulso Any chance you can bisect to figure out which alpha release broke it? Thanks for your help!

@jbanulso
Copy link
Author

@shilman Actually it seems that it doesn't even work in 6.0.0 - I think it was working for me because I used to have a custom wrapper around stories.

I found issue #10789, where it's said that this problem is solved, but it doesn't look like it. I wonder if this has worked at all since layout: 'centered' was introduced? 🤔

@ndelangen
Copy link
Member

@shilman shilman modified the milestones: 6.1 docs, 6.2 docs Nov 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@hiepxanh
Copy link

bump

@stale stale bot removed the inactive label Jan 27, 2021
@shilman shilman added the todo label Feb 21, 2021
@shilman shilman modified the milestones: 6.2 docs, 6.2 candidates Mar 4, 2021
@shilman shilman added the small label Jun 8, 2021
@shilman shilman added this to the 6.4 improvements milestone Jun 8, 2021
@ndelangen
Copy link
Member

I will look at this today

@shilman
Copy link
Member

shilman commented Oct 29, 2021

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.23 containing PR #16506 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants