Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from storybook 6.0.x to 6.1.10 breaks custom theming colors #13388

Closed
slavoroi opened this issue Dec 6, 2020 · 5 comments
Closed
Milestone

Comments

@slavoroi
Copy link

slavoroi commented Dec 6, 2020

Describe the bug
Setting barBg: #7e52a2 custom theme changes Shortcuts/Search bar background-color and we can't customize it.

To Reproduce

  1. Update to storybook 6.1.10
  2. Create a custom theme
import {create} from '@storybook/theming/create';

const colorPrimary = '#7e52a2';
const colorSecondary = '#f5a623';


export const Light = create({
  barBg: colorPrimary,
...

  1. The UI is ugly and unintended components changes their background colors as well.

Expected behavior
Setting top bar won't have any effect on the search bar/ shortcuts buttons OR we can customize search search bar/ shortcuts colors as well.

Screenshots
image

@nerisina
Copy link

I am having the same issue.

@shilman
Copy link
Member

shilman commented Feb 13, 2021

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.26 containing PR #13895 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 13, 2021
@shilman
Copy link
Member

shilman commented Feb 14, 2021

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.18 containing PR #13895 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

@slavoroi
Copy link
Author

thanks! amazing, ill check it.

@nerisina
Copy link

The search input on the left nav is working correctly but I think still some bugs in the custom theme configuration.

The switch buttons under control it's taking the toolbar background.

UI-Elements-Form-Controls-Buttons-Primary-⋅-Storybook

The arrows in the left nav on hover, focus, and the active effect are taking the parameters from barSelectedColor

left-nav-Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants