Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: The background color switch does not work dynamically in docs tabs. #13480

Closed
ThibaudAV opened this issue Dec 18, 2020 · 4 comments
Closed

Comments

@ThibaudAV
Copy link
Contributor

Describe the bug

The background color switch does not work dynamically in docs tabs.
Apparently only on Angular

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://next--storybookjs.netlify.app/angular-cli/?path=/story/welcome--to-storybook'
  2. Click on 'Docs' tab
  3. Click on
    image
    And change color
  4. See error
    The background color dose not change.
    I have the impression that it is decorators who are not called 🤔

Expected behavior
The background must change as in canvas

Screenshots

Video.MP4.684x386.mp4

It doesn't only work on the docs part

Code snippets
🤷‍♂️

System
na

Additional context
na

@ThibaudAV
Copy link
Contributor Author

This issue seems to have corrected the 🐛 . but only for the React part ?? :note-sure:
#12305

@shilman
Copy link
Member

shilman commented Dec 19, 2020

@ThibaudAV I think this might be an issue for stories that run in iframes (angular), but has been fixed for inline stories (most other popular frameworks). @yannbf can you confirm?

@ThibaudAV
Copy link
Contributor Author

@shilman you're right it seems to be related to iframe

So I'm going to propose PR to add "inline" stories support for addon docs with angular.
This is my christmas present 🎁 xD

@shilman
Copy link
Member

shilman commented Jan 29, 2021

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.19 containing PR #13525 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants