Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine and set a main landmark #13794

Closed
adagar opened this issue Feb 2, 2021 · 1 comment
Closed

Determine and set a main landmark #13794

adagar opened this issue Feb 2, 2021 · 1 comment

Comments

@adagar
Copy link
Contributor

adagar commented Feb 2, 2021

Is your feature request related to a problem? Please describe
When running Axe assertions, one of the errors is the lack of a main landmark. Landmarks are an essential tool for people using non-traditional modes of navigation, so this is a change that has high-impact for a11y-users and little to no impact for other users.

Describe the solution you'd like
An element, likely the DOM node that contains the visual and code view of elements should be changed from a generic div element to a main one.
Screen Shot 2021-02-02 at 3 58 07 PM

NOTE: Due to the nature of nested documents (https://www.w3.org/TR/wai-aria-practices/examples/landmarks/main.html#:~:text=The%20main%20landmark%20should%20be,should%20have%20a%20unique%20label.) a <main> landmark should also be determined for the content inside of the iFrame, though I understand that this content is considered user generated and beyond the scope of core story-book features.

Are you able to assist to bring the feature to reality?
Yes, I can. This should be a small change.

Additional context
Add any other context or screenshots about the feature request here.

@shilman
Copy link
Member

shilman commented Feb 13, 2021

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.26 containing PR #13827 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants