Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types of color blindness incorrectly ordered in the accessibility add-on #14767

Closed
maya opened this issue Apr 30, 2021 · 2 comments
Closed

Types of color blindness incorrectly ordered in the accessibility add-on #14767

maya opened this issue Apr 30, 2021 · 2 comments

Comments

@maya
Copy link
Contributor

maya commented Apr 30, 2021

Describe the bug
In the accessibility add-on, the color blindness listings should be ordered by most to least common types of color blindness.

Use the order in this list: https://www.nei.nih.gov/learn-about-eye-health/eye-conditions-and-diseases/color-blindness/types-color-blindness

Importantly, Deuteranomaly should be first as it's by far the most common.

Note: it's fine to leave blurred vision first (as it's also super common) and this issue is just about the color blindness.

To Reproduce
Make sure the accessibility add-on is on, go to the storybook library, click on the accessibility button, view the dropdown.

System
N/A

Additional context
Screen Shot 2021-04-29 at 6 03 38 PM

@shilman
Copy link
Member

shilman commented Apr 30, 2021

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-alpha.17 containing PR #14768 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Apr 30, 2021
@maya
Copy link
Contributor Author

maya commented Apr 30, 2021

Awesome, thanks! The other improvement I could see is adding categories like this but that is probably not as straightforward as these changes.

707CAC2F-4CAC-4C61-808D-98DDA1B101DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants