Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue inline rendering broken in 6.4-beta #16223

Closed
2 tasks done
shilman opened this issue Oct 4, 2021 · 1 comment
Closed
2 tasks done

Vue inline rendering broken in 6.4-beta #16223

shilman opened this issue Oct 4, 2021 · 1 comment
Labels
addon: docs args bug vue
Milestone
6.2 perf

Comments

@shilman
Copy link
Member

shilman commented Oct 4, 2021 •
edited

Running npx sb@next repro generates a storybook where the button stories don't render properly on the Docs tab, which is causing the new e2e docs test to fail.

However:

  • The button borders render correctly
  • Vue stories in the monorepo render correctly

Therefore it appears that inline rendering is at least partially working, FWIW.

=> So perhaps it is a bug with Args in @storybook/vue?

Possibly related to this? #16154
@shilman shilman added this to the 6.2 perf milestone Oct 4, 2021
@shilman shilman added the args label Oct 4, 2021
This was referenced Oct 4, 2021
Merged
Merged
@shilman
Copy link
Member Author

shilman commented Oct 8, 2021

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.7 containing PR #16279 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs args bug vue
Projects
None yet
Milestone
6.2 perf
Development

No branches or pull requests
1 participant
@shilman