New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo link allow for the removal of target="_blank" #16782
Comments
Hi I can look into this issue. Just wanted to confirm before I make changes in the code, do we really want to remove target="_blank" or need to provide a configuration, so that users can configure how they want to navigate to the brand site? I can see this change was done as part of the pull request https://github.com/storybookjs/storybook/pull/6106/files. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
@waseemahmad31 I would say "provide a configuration".
From which version of Storybook would this new config be accessible? |
We have the same issue, running SB 6.5.9 React. |
I feel that If it's a normal hyperlink (without But if - <a href="#" target="_blank">...</a>
+ <a href="#" target="_blank" rel="noopener noreferrer">...</a> Reasons to avoid |
I was just trying to achieve the same and it seems next to
|
It's a shame to see this issue closed. Defaulting to an experience with both security and performance issues is a poor user experience. It may be possible to find a "workaround" by opting-in to using |
Is your feature request related to a problem? Please describe
Currently, when configuring a URL for the logo in the top part of the sidebar it always opens up a new tab. Ideally, this should just take you to the page you configured it for without opening a new tab, especially when it is a page that has been configured as a home page.
Describe the solution you'd like
I would like to be able to flag the URL not to open a new tab, for example in the theming options.
Describe alternatives you've considered
There is currently no workaround, except for accepting the situation as is. Opening a new tab, closing the old one.
Are you able to assist to bring the feature to reality?
Potentially, if pointers are given.
Additional context
This is related to the comment at this issue #10647 (comment)
The text was updated successfully, but these errors were encountered: