Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next 12 + postcss 8 + storybook = eldritch occurrences. Carl Pilcher to blame? #17178

Closed
asktree opened this issue Jan 9, 2022 · 7 comments
Closed

Comments

@asktree
Copy link

asktree commented Jan 9, 2022

Describe the bug
image

To Reproduce
My package.json:

{
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "storybook": "start-storybook -p 6006",
    "build-storybook": "build-storybook"
  },
  "dependencies": {
    "@headlessui/react": "^1.4.1",
    "@heroicons/react": "^1.0.4",
    "@typeform/embed-react": "^1.1.5",
    "next": "^12.0.7",
    "react": "^17.0.2",
    "react-dom": "^17.0.2"
  },
  "devDependencies": {
    "@babel/core": "^7.16.7",
    "@storybook/addon-actions": "^6.4.9",
    "@storybook/addon-essentials": "^6.4.9",
    "@storybook/addon-links": "^6.4.9",
    "@storybook/react": "^6.4.9",
    "@types/react": "^17.0.26",
    "autoprefixer": "^10.2.6",
    "babel-loader": "^8.2.3",
    "postcss": "^8.3.5",
    "tailwindcss": "^2.2.4",
    "typescript": "^4.4.3"
  }
}

Run npm run storybook

System
Environment Info:

System:
OS: macOS 11.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 16.13.0 - ~/.volta/tools/image/node/16.13.0/bin/node
Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
npm: 8.1.0 - ~/.volta/tools/image/node/16.13.0/bin/npm
Browsers:
Chrome: 97.0.4692.71
Firefox: 95.0.2
Safari: 14.1
npmPackages:
@storybook/addon-actions: ^6.4.9 => 6.4.9
@storybook/addon-essentials: ^6.4.9 => 6.4.9
@storybook/addon-links: ^6.4.9 => 6.4.9
@storybook/react: ^6.4.9 => 6.4.9

Additional context
When I encountered this bug, VSCode started becoming unresponsive and had to be closed. Also, my dogs started barking, my cat started hissing at the computer, and my kitchen cabinets began flying open and closed violently.

@nzacca
Copy link
Contributor

nzacca commented Jan 9, 2022

This has something to do with faker.js being pulled recently. See here for details: faker-js/faker#24

It is not clear to me as yet what the offending package is (storybook doesn't appear to be using faker). Debugging this at the moment.

@nzacca
Copy link
Contributor

nzacca commented Jan 9, 2022

Issue is with color.js which was recently updated here: https://github.com/Marak/colors.js/commits/master

Need to lock down that package to this commit: ljharb/colors.js@7ddd6a3

This is being used by cli-table3 which is used by Storybook.

Edit: Updated the commit to use @ljharb fork instead.

@ljharb
Copy link
Contributor

ljharb commented Jan 9, 2022

I would point to the github tag for v1.4.0 (ljharb/colors.js@baa0e1c). Feel free to do so on my fork, as it won't be going away.

@nzacca
Copy link
Contributor

nzacca commented Jan 9, 2022

Thanks @ljharb .

@nzacca
Copy link
Contributor

nzacca commented Jan 9, 2022

cli-table3 has been updated to lock the version. cli-table/cli-table3#251

@nzacca
Copy link
Contributor

nzacca commented Jan 10, 2022

Suggest closing this in favor of: #17179

@shilman
Copy link
Member

shilman commented Jan 10, 2022

Closing as dupe to #17179 which has been resolved in 6.4 / 6.5-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants