Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values set in addons.setConfig get ignored once the storybook is uploaded to S3 #17335

Closed
neil-morrison44 opened this issue Jan 26, 2022 · 1 comment

Comments

@neil-morrison44
Copy link

Describe the bug
Weird one - I've got a manager.js file like

import { addons } from "@storybook/addons"

console.log("addons.setConfig")
addons.setConfig({
  showNav: false,
  panelPosition: "bottom",
})

When the storybook is deployed to S3 I get the console.log but the nav is shown and the panelPosition is on the right, but the exact same storybook build running in a local HTTP server will hide the nav & show the panel at the bottom.

To Reproduce

I've attempted to reproduce without uploading to S3 but I've failed to get it not working locally, I can probably DM an S3 link to one of our less-populated storybooks though.

System

Environment Info:

  System:
    OS: Linux 5.10 Debian GNU/Linux 10 (buster) 10 (buster)
    CPU: (8) arm64 unknown
  Binaries:
    Node: 16.13.0 - /usr/bin/node
    Yarn: 1.22.15 - /usr/bin/yarn
    npm: 8.1.0 - /usr/bin/npm
  npmPackages:
    @storybook/addon-a11y: ^6.4.14 => 6.4.14 
    @storybook/addon-actions: ^6.4.13 => 6.4.14 
    @storybook/addon-essentials: ^6.4.14 => 6.4.14 
    @storybook/addon-jest: ^6.4.14 => 6.4.14 
    @storybook/addon-links: ^6.4.14 => 6.4.14 
    @storybook/addon-postcss: ^2.0.0 => 2.0.0 
    @storybook/builder-webpack5: ^6.4.14 => 6.4.14 
    @storybook/manager-webpack5: ^6.4.14 => 6.4.14 
    @storybook/react: ^6.4.14 => 6.4.14 
    @storybook/testing-react: ^1.2.3 => 1.2.3 

Additional context
The actual build happens via a github workflow, the S3 bucket is visited using its long name & over https.
Sorry I can't be of more help - it's a weird issue that's been effecting us for a while now across a few different storybooks.

@shilman
Copy link
Member

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

@shilman shilman closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants