New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook adding webpack 4 (and other older dependencies) on a webpack 5 install. #17436
Comments
@SnakeSVx this is planned for 7.0 since it's a breaking change. we've also started prebundling some of our dependencies to avoid conflicts with user dependencies, and this change will hopefully make it into 6.5. |
Just to clarify, Storybook is not compatible with Angular 13+ until V7? |
@BenRacicot storybook is compatible with Angular 13 |
After upgrading to npm 8 there is a workaround that can be done for this as well by forcing the webpack version. This prevents the old webpack and it's dependencies to be added to the node_modules. (cleans up about 200 dependencies). |
@shilman thanks for responding. Is there a demo project available to reference? I've ran through all the docs and have errors everywhere when adding SB to my project. (which seem to relate to this issue, btw) |
@BenRacicot does this work for you? https://github.com/storybookjs/repro-templates/tree/next/angular cc @yannbf |
@shilman I don't want to hijack this issue but no it's still not clear. That demo has no angular.json file so not sure what purpose that project serves. Perhaps the answer is there but I can't see it. Looking at storybook.js.org/docs/angular/get-started/install it seems there is an issue with the instructions.
Further down the page it seems to be saying that SB must be installed in its own Angular workspace? If so maybe the docs can be updated to explain that SB cannot be simply added to your project with |
@BenRacicot there's an angular.json file right here https://github.com/storybookjs/repro-templates/blob/next/angular/angular.json |
My apologies, yes that exists, but it does not match the docs instructions. |
We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:
|
Describe the bug
Storybook seems to be added webpack 4 as dependency even though webpack 5 is being used.
npm install warnings:
To Reproduce
Latest nx version workspace with storybook installed.
System
Please paste the results of
npx sb@next info
here.Additional context
Remove the webpack 4 dependency or make it optional. So that you can either pick webpack 4 or webpack 5.
The text was updated successfully, but these errors were encountered: