Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-interactions: panel does not reset on HMR #17570

Closed
yannbf opened this issue Feb 24, 2022 · 3 comments
Closed

Addon-interactions: panel does not reset on HMR #17570

yannbf opened this issue Feb 24, 2022 · 3 comments

Comments

@yannbf
Copy link
Member

yannbf commented Feb 24, 2022

Describe the bug
A clear and concise description of what the bug is.

addon-bug.mp4

To Reproduce
1 - Open a story with interactions
2 - Click on Go to start to keep the RUNS status
3 - Make code changes
4 - HMR should rerun the interaction but it does not

@lonyele
Copy link
Member

lonyele commented Mar 8, 2022

Q1. After step 3, I got an error like these. This doesn't happen to you?
스크린샷 2022-03-08 오전 10 30 44
스크린샷 2022-03-08 오전 10 29 16

Q2. When you click the !!!hello's file line(VM2051 main.~~~.js:126), can you see the updated code console.log('!!!hello world') at the Source tab?

Q3. Can you reproduce when you move console.log(~) to before the await code?
Since the interaction state goes to the start, console.log('!!!hello world') shouldn't be logged? From my local, I could get the updated log if I move before any await

After I fix the above errors, I got to HMR working. But maybe, I'm the only one having these errors?

@shilman
Copy link
Member

shilman commented May 20, 2022

OOPS

@shilman
Copy link
Member

shilman commented Jun 21, 2022

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.6 containing PR #18516 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants