Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug in @storybook/vue3] some actions trigger behavior not work suit with vue3 best practice. #17671

Closed
Matrixbirds opened this issue Mar 9, 2022 · 1 comment

Comments

@Matrixbirds
Copy link

Matrixbirds commented Mar 9, 2022

Describe the bug
I got this warning, when i am integrate element-plus into storybook,
I was set on the parameters option with below script

export default {
    parameters: {
        handles: ['click button']
    }
}

And then click the el-button on the page of stories will trigger click event succeed, but i will got many warnings.
If i used another way to bind events manually, the warning log will dismiss.

To Reproduce

  • manually trigger click in this stories you will see the log stack as below
runtime-core.esm-bundler.jss:38 [Vue warn]: Avoid app logic that relies on enumerating keys on a component instance. The keys will be empty in production mode to avoid performance overhead.
warn @ runtime-core.esm-bundler.jss:38
PublicInstanceProxyHandlers.ownKeys @ runtime-core.esm-bundler.jss:6817
stringify @ index.jss:401
send @ index.jss:159
handler @ index.jss:90
emit @ index.jss:100
actionHandler @ action.jss:81
handler @ withActions.jss:92
vendors-node_modules_storybook_addon-actions_6_4_19_node_modules_storybook_addon-actions-258cbc.manager.bundle.js:118891 [Violation] 'setTimeout' handler took 124ms
[Violation] Forced reflow while executing JavaScript took 48ms

System and environments

  • MacOS
  • Node dependencies
      '@storybook/addon-actions': ^6.4.19
      '@storybook/addon-essentials': ^6.4.19
      '@storybook/addon-links': ^6.4.19
      '@storybook/builder-webpack5': ^6.4.19
      '@storybook/manager-webpack5': ^6.4.19
      '@storybook/vue3': ^6.4.19
@shilman shilman added vue3 and removed needs triage labels Jun 8, 2023
@shilman shilman closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@shilman
Copy link
Member

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants