Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the title when Storybook is loading from "Webpack app" to "Storybook loading..." #17709

Closed
MichaelArestad opened this issue Mar 14, 2022 · 4 comments
Assignees

Comments

@MichaelArestad
Copy link
Contributor

Describe the bug
When building storybook, the title shows "Webpack App". Can we change it to "Storybook loading..."?

I found the title referenced in these files, but they are untracked so are likely not where the change needs to be made:

lib/manager-webpack4/prebuilt/index.html
lib/manager-webpack5/prebuilt/index.html

@pmcelhaney
Copy link

Looks like it's configured here: https://github.com/jantimon/html-webpack-plugin#options

@pmcelhaney
Copy link

Need to add a title property here:

new HtmlWebpackPlugin({
filename: `index.html`,
// FIXME: `none` isn't a known option
chunksSortMode: 'none' as any,
alwaysWriteToDisk: true,
inject: false,
template,
templateParameters: {
version,
globals: {
CONFIG_TYPE: configType,
LOGLEVEL: logLevel,
FEATURES: features,
VERSIONCHECK: JSON.stringify(versionCheck),
RELEASE_NOTES_DATA: JSON.stringify(releaseNotesData),
DOCS_MODE: docsMode, // global docs mode
PREVIEW_URL: previewUrl, // global preview URL
SERVER_CHANNEL_URL: serverChannelUrl,
},
headHtmlSnippet,
},
}) as any as WebpackPluginInstance,

and here:

new HtmlWebpackPlugin({
filename: `index.html`,
// FIXME: `none` isn't a known option
chunksSortMode: 'none' as any,
alwaysWriteToDisk: true,
inject: false,
template,
templateParameters: {
version,
globals: {
CONFIG_TYPE: configType,
LOGLEVEL: logLevel,
FEATURES: features,
VERSIONCHECK: JSON.stringify(versionCheck),
RELEASE_NOTES_DATA: JSON.stringify(releaseNotesData),
DOCS_MODE: docsMode, // global docs mode
PREVIEW_URL: previewUrl, // global preview URL
SERVER_CHANNEL_URL: serverChannelUrl,
},
headHtmlSnippet,
},
}) as any as WebpackPluginInstance,

@MichaelArestad
Copy link
Contributor Author

@pmcelhaney Thanks! I will take care of this sometime this week!

@shilman
Copy link
Member

shilman commented Jul 2, 2022

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.10 containing PR #17935 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants