Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in the bundle makes it hard to deploy to static site hosting #19065

Open
azer opened this issue Aug 31, 2022 · 2 comments
Open

Comments

@azer
Copy link

azer commented Aug 31, 2022

Describe the bug
I've tried deploying a simple Storybook setup to following hosting providers and all of them had issues:

  • Firebase
  • Netlify
  • Cloudflare Pages
  • Github Pages

The issues were:

  • sb-addons/.storybook/manager.mjs missing
  • extension folders missing (e.g @storybook/addon-controls/manager.mjs)

My guess is that these services filter out certain file patterns. Storybook could have better cleaner & simpler output layout, an option to just produce a simple static bundle would have been perfect.

To Reproduce
Try deploying to one of the hosting providers in the list.

System
404 errors usually. The build is compiled successfully without any error.

@WesleyKapow
Copy link

Just hit this.

You can add a .nojekyll file at the root of your github pages repo. In my case, I added it to public/ so that it gets populated in the root directory when my pages get built.

https://github.blog/2009-12-29-bypassing-jekyll-on-github-pages/

WesleyKapow added a commit to zeus-health/ctw-component-library that referenced this issue Nov 23, 2022
We need to tell github pages to not use jekyll. See storybookjs/storybook#19065 for details.
@reintroducing
Copy link

I can confirm that adding a .nojekyll file in beta 15 to my GH Pages branch fixed the issue of sb-addons/.storybook/manager.mjs being missing. Thanks @WesleyKapow, but would be nice if SB did this automatically rather than having to add an extra step to the build process prior to deploying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants