Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error message you get when using storiesOf in ssv7 mode is very clear #20146

Closed
3 tasks
shilman opened this issue Dec 8, 2022 · 1 comment · Fixed by #21451
Closed
3 tasks

Ensure error message you get when using storiesOf in ssv7 mode is very clear #20146

shilman opened this issue Dec 8, 2022 · 1 comment · Fixed by #21451
Assignees
Labels
maintenance User-facing maintenance tasks story index

Comments

@shilman
Copy link
Member

shilman commented Dec 8, 2022

Does it explain what's wrong? Does it link to the appropriate MIGRATION.md entry? Does the MIGRATION.md explain what to do to upgrade (or downgrade to ssv6)?

  • Test in Vite project
  • Test in Webpack project
  • Do we want to add an automigration as well?
@tmeasday
Copy link
Member

tmeasday commented Mar 1, 2023

Currently (in Vite, although I think likely the same in WP), it says on the terminal (and in the browser, if you have it open):

WARN 🚨 Unable to index ./src/components/IAlert/examples/index-storiesOf.stories.ts:
WARN   Error: CSF: unexpected storiesOf call /Users/tom/GitHub/inkline/inkline/src/components/IAlert/examples/index-storiesOf.stories.ts (line 14, col 0)
WARN
WARN More info: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#story-store-v7
WARN     at enter (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:66:5304)
WARN     at NodePath._call (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:26692)
WARN     at NodePath.call (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:26514)
WARN     at NodePath.visit (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:27650)
WARN     at TraversalContext.visitQueue (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:61144)
WARN     at TraversalContext.visitSingle (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:60779)
WARN     at TraversalContext.visit (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:61469)
WARN     at traverseNode (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:62041)
WARN     at NodePath.visit (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:27819)
WARN     at TraversalContext.visitQueue (/Users/tom/GitHub/inkline/inkline/node_modules/@storybook/csf-tools/dist/index.js:58:61144)

The place it points to (https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#story-store-v7) is a 6.5 migration note and isn't super helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks story index
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants