Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static build doesn't work on Safari #234

Closed
vdumitraskovic opened this issue Jun 6, 2016 · 2 comments
Closed

Static build doesn't work on Safari #234

vdumitraskovic opened this issue Jun 6, 2016 · 2 comments

Comments

@vdumitraskovic
Copy link

On Safari, static build doesn't initialize because of the source map (manager.js.map) not found (url not resolved). When source mapping comment (sourceMappingUrl) is removed from manager.js in dist folder, everything works as expected.
thani-sh added a commit that referenced this issue Jun 7, 2016
@thani-sh
Copy missing manager.js.map file
b27fdf6 
The sourcemap file for manager.js was not copied when
building the static storybook bundle. Which seems to cause
issues with Safari browser.

The static build seems to work fine on Safari 9. But better
fix the issue anyways.

Fixes #234
@thani-sh thani-sh mentioned this issue Jun 7, 2016
Merged
@thani-sh thani-sh reopened this Jun 7, 2016
@thani-sh
Copy link
Contributor

thani-sh commented Jun 7, 2016

Hi @smesko85
Just released v1.29.1 to include the source map file. Can you confirm whether it works?
Thanks for reporting the issue.

@vdumitraskovic
Copy link
Author

Hi @mnmtanish,
It works perfectly! Thank You for quick response!

@Watemlifts Watemlifts mentioned this issue Mar 14, 2021
Closed
@dudusae dudusae mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thani-sh @vdumitraskovic