Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/addon-viewport@7.6.0 is broken #25036

Closed
jpzwarte opened this issue Nov 29, 2023 · 8 comments · Fixed by #25107
Closed

[Bug]: @storybook/addon-viewport@7.6.0 is broken #25036

jpzwarte opened this issue Nov 29, 2023 · 8 comments · Fixed by #25107

Comments

@jpzwarte
Copy link
Member

Describe the bug

I think @storybook/addon-viewport version 7.6.0 is broken: it references import { L } from './main-c55d8855.js'; in index.d.ts which doesn't exist:

CleanShot 2023-11-29 at 14 21 20@2x
CleanShot 2023-11-29 at 14 21 25@2x

To Reproduce

System

-

Additional context

@ndelangen
Copy link
Member

I'm not seeing this when I generate production dist for @storybook/addon-viewports:

Screenshot 2023-11-30 at 10 21 58

@jpzwarte
Copy link
Member Author

Weird, it is there in the published version: https://www.npmjs.com/package/@storybook/addon-viewport?activeTab=code

@jlowcs
Copy link

jlowcs commented Nov 30, 2023

Same issue in @storybook/addon-viewport@7.6.1

@JReinhold
Copy link
Contributor

This is reproducible when compiling in --no-link mode on the main branch.

@mhaberl
Copy link

mhaberl commented Dec 3, 2023

Same issue in @storybook/addon-viewport@7.6.2 and 7.6.3

@ndelangen
Copy link
Member

@JReinhold some difference in how the output is generated between main and next?
I ran it on next and wasn't able to reproduce.

@kasperpeulen
Copy link
Contributor

Gotta PR for this @ndelangen

@kasperpeulen
Copy link
Contributor

#25107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants