Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: sb upgrade does not upgrade @storybook/preset-create-react-app #25645

Closed
Tracked by #25432
valentinpalkovic opened this issue Jan 18, 2024 · 3 comments
Closed
Tracked by #25432

[Bug]: sb upgrade does not upgrade @storybook/preset-create-react-app #25645

valentinpalkovic opened this issue Jan 18, 2024 · 3 comments
Assignees
@valentinpalkovic
Labels
bug cli compatibility with other tools sev:S2

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Jan 18, 2024 •
edited
Loading

Describe the bug

Running sb upgrade doesn't upgrade @storybook/preset-create-react-app

To Reproduce

  1. Clone https://github.com/jonathanhuang13/storybook-repro
  2. Run npx storybook@next upgrade
  3. @storybook/preset-create-react-app isn't upgraded to its latest version

Tasks

  • Throw an error as soon as react-scripts < 5 is recognized and notify the user that Storybook 8 doesn't support react-scripts < 5

System

No response

Additional context

No response
@valentinpalkovic
Copy link
Contributor Author

It has something to do with this check: https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/upgrade.ts#L162

We don't upgrade @storybook/preset-create-react-app if react-scripts' version is smaller than 5.0.0. Isn't this potentially very error prone to have different versions of monorepo packages installed? @shilman WDYT?

@valentinpalkovic valentinpalkovic added this to the 8.0-RC milestone Jan 18, 2024
@valentinpalkovic
Copy link
Contributor Author

As discussed with @shilman, we should prohibit using Storybook 7/8 with CRA < 5. Same goes for Vue 2 with Storybook 8

@valentinpalkovic valentinpalkovic mentioned this issue Feb 1, 2024
Closed
@valentinpalkovic valentinpalkovic removed this from the 8.0-RC milestone Feb 1, 2024
@valentinpalkovic valentinpalkovic self-assigned this Feb 5, 2024
@valentinpalkovic
Copy link
Contributor Author

Handled in #25911

@valentinpalkovic valentinpalkovic mentioned this issue Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
bug cli compatibility with other tools sev:S2
Projects
No open projects
Storybook 8.0 Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shilman @valentinpalkovic