Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/preview@7.6.0 contains breaking change #25735

Closed
thepassle opened this issue Jan 24, 2024 · 3 comments
Closed

[Bug]: @storybook/preview@7.6.0 contains breaking change #25735

thepassle opened this issue Jan 24, 2024 · 3 comments

Comments

@thepassle
Copy link
Contributor

thepassle commented Jan 24, 2024

Describe the bug

@storybook/preview@7.5.3 has an export for globals:
image

We import it here: https://github.com/modernweb-dev/web/blob/master/packages/storybook-builder/src/index.ts#L4C1-L5C1

import { globals } from '@storybook/preview/globals';

However, in version 7.6.0 it seems that the export has changed to something different, resulting in a breaking change for our storybook builder (@web/storybook-builder):

image

To Reproduce

No response

System

No response

Additional context

No response

@JReinhold
Copy link
Contributor

Sounds about right. AFAIK there was never an intention for other packages than Storybook core packages to use that export, which is why it wasn't considered a breaking change to change it.

I think we can bring back the original globals export with little effort in 7.6 though.

@shilman shilman added the core label Jan 24, 2024
@thepassle
Copy link
Contributor Author

I could be wrong, but I think us using this export was one of the things we discussed a while ago with some members of the storybook team, but I forget the details unfortunately. For now it seems like we can just update to the globalsNameReferenceMap because those seem to be the same object, but figured I'd report the issue so at least y'all are aware of it. I'll close this issue for now then :) Do be advised that third party Builders may depend on this package however

@JReinhold
Copy link
Contributor

this export was one of the things we discussed a while ago with some members of the storybook team

Could very well be! A lot of nuances and details here and I won't pretend to know everything and every usage.

Do be advised that third party Builders may depend on this package however

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants