Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App [Frameworks], can they be built externally like add-ons? #2841

Closed
jasonmacdonald opened this issue Jan 25, 2018 · 9 comments
Closed

Comments

@jasonmacdonald
Copy link

I just came across this project and it looks great! In fact, I have built tooling for my own project with a similar goal, but not nearly as "complete". My question is around supporting new frameworks; do they have to be built by this team and deeply integrated, or can they be built similar to add-ons? Specifically, I would like to use this with the Markojs framework, and I don't mind doing the work if I can build and run it without needing to get it included directly to this repo (not that I couldn't submit it).

There doesn't seem to be docs relating to how to include new apps the same way there is for add-ons, so wasn't sure if this was possible as an external "app" that people could just require in an use.

@Hypnosphi
Copy link
Member

We have some ongoing work on extracting common parts of the apps: #2240

It should make supporting more frameworks a lot easier, and probably allow external apps. Feel free to contact us on slack if you'd like to collaborate on that: https://now-examples-slackin-rrirkqohko.now.sh/

@ndelangen
Copy link
Member

Hi @jasonmacdonald Let's talk! I'd love to work with your to get storybook to support markojs!

You can PM me on our slack or on twitter, what you prefer!

@shilman
Copy link
Member

shilman commented Jan 26, 2018

@jasonmacdonald To add to what both of these guys just said, supporting a new framework is as simple as creating a new NPM package, and it doesn't necessarily have to be part of the Storybook repo (tho we'd love to include it). We're still documenting and improving that process, but your best bet is to work with @ndelangen to get yourself up and running. After success adding Vue, Angular, and soon Polymer, it's getting more and more streamlined. 😀

@jasonmacdonald
Copy link
Author

jasonmacdonald commented Jan 26, 2018

Awesome! It was the "hidden" bits I was concerned about. I couldn't tell at first glance if all the moving parts were encapsulated within the apps themselves or not. Perhaps I'll start by just taking a crack at adding Marko as an app, and I'll ping you guys if I run into any major snags. Cheers!

I made a fork and joined the slack channel (thanks for that @Hypnosphi ). I'll keep you updated once I get going. Need to spend some time spelunking the code to see how things are set-up :)

@sixmen
Copy link
Member

sixmen commented Jan 26, 2018

I'm also making a storybook app, for Mithril which I use.

What is your plan for these apps?
If you want to include apps for minor frameworks to the storybook repository, I will make a PR.
Or, I will publish it as own package.

@ndelangen
Copy link
Member

@sixmen @jasonmacdonald I'd invite both of you for a skype call so I can explain to process. I think that will really help you along a lot.

And it would also give us the opportunity to meet and connect the communities a bit.

@igor-dv
Copy link
Member

igor-dv commented Jan 26, 2018

@ndelangen, there was also a question about Stencil recently in #support. Did something happen with this?

@stale
Copy link

stale bot commented Mar 12, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Mar 12, 2018
@stale
Copy link

stale bot commented Apr 11, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants