Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addons: Backgrounds] - Duplicating default color block #5775

Closed
CodeByAlex opened this issue Feb 26, 2019 · 2 comments
Closed

[Addons: Backgrounds] - Duplicating default color block #5775

CodeByAlex opened this issue Feb 26, 2019 · 2 comments

Comments

@CodeByAlex
Copy link
Member

CodeByAlex commented Feb 26, 2019

Describe the bug
The default color block in the backgrounds tab is being duplicated on every switch of a tab and when the default block is clicked

To Reproduce
Steps to reproduce the behavior:

  1. Set up project
  2. Apply the background addon globally in the addonjs and configjs
    (May be a backward compatibility issue)
addDecorator(withBackgrounds([
  { name: 'twitter', value: '#00aced' },
  { name: 'facebook', value: '#3b5998' },
]));

The following way of adding backgrounds does not work in angular

addParameters({
  backgrounds: [
    { name: 'twitter', value: '#00aced'},
    { name: 'facebook', value: '#3b5998' },
  ],
});
  1. Go to the background tab and click on the default block

Expected behavior
One default block should appear rather than many

Screenshots

duplicate-sb-block

System:

  • Framework: [Angular]
  • Version: [5.0.0-rc.6]
@CodeByAlex
Copy link
Member Author

CodeByAlex commented Feb 26, 2019

@shilman , Also What is this:
image
Is that supposed to show up in the toolbar when using backgrounds?

@shilman shilman modified the milestones: v5.0.0, 5.0.x Mar 5, 2019
@CodeByAlex
Copy link
Member Author

This issue has been resolved and I am now seeing the expected result with higher versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants