-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot start when installed using yarn pnp, improvement to webpack config needed #6905
Comments
I have been trying to fix the Webpack config manually for 24 hours now, without success |
Some pointers on the related issue here #6899 (comment) |
This file might be a good culprit ? https://github.com/storybooks/storybook/blob/master/app/react/src/server/cra-config.js |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Module not found: Error: Can't resolve '@storybook/addon-knobs/register' in |
@TroySchmidt got a project you could share? AFAIK the node resolve algorithm should be able to find from node perspective there's no difference between Are you sure you installed the module? |
I resolved this by blowing away |
Now I do have a custom baseUrl set in tsconfig.json. Without having the |
@TroySchmidt what do you mean "don't work"? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Describe the bug
When running storybook in a package installed using yarn pnp, storybook does not start.
This is caused by the webpack config not using https://github.com/arcanis/pnp-webpack-plugin
To Reproduce
Steps to reproduce the behavior:
package.json
:yarn add @storybook/channels @emotion/core @emotion/styled emotion-theming
to kind of fix this first bug Trying to require the package "@emotion/core" without it being listed in its dependencies #6899storybook start
Expected behavior
Storybook works, loading modules using pnp-webpack-plugin
Screenshots
Code snippets
If applicable, add code samples to help explain your problem.
System:
Additional context
Running with yarn pnp
See also this issue #6899
The text was updated successfully, but these errors were encountered: