Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular addParameters missing from index.d.ts #6927

Closed
chriscarpenter12 opened this issue May 31, 2019 · 1 comment
Closed

Angular addParameters missing from index.d.ts #6927

chriscarpenter12 opened this issue May 31, 2019 · 1 comment
Labels
angular typescript
Milestone
5.1.0

Comments

@chriscarpenter12
Copy link

chriscarpenter12 commented May 31, 2019 •
edited

Describe the bug
addParameters is not defined in app/angular/src/client/preview/index.d.ts

To Reproduce
Import addParameters into storybook config.

Expected behavior
IDE warnings.

Screenshots
Screenshot from 2019-05-31 14-03-17

System:

  • OS: Ubuntu 18.04
  • Framework: Angular
  • Version: 5.0.11
@chriscarpenter12 chriscarpenter12 mentioned this issue May 31, 2019
Merged
@shilman
Copy link
Member

shilman commented Jun 4, 2019

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.0-rc.5 containing PR #6929 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 4, 2019
@shilman shilman added this to the 5.1.0 milestone Jun 4, 2019
@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
angular typescript
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@chriscarpenter12 @shilman