Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Extension Mismatch in storybook/app/angular/src/server/options.ts #7406

Closed
spenceryue opened this issue Jul 12, 2019 · 1 comment
Closed

Comments

@spenceryue
Copy link

spenceryue commented Jul 12, 2019

Describe the bug
In the source file, the code reads require.resolve('./framework-preset-angular.js'), but no such file exists in the storybook/app/angular/src/server/ directory. Instead there is a frame-work-preset-angular.ts file.

There doesn't seem to be an error message, even though require.resolve does usually throw Error: Cannot find module '...' when the argument can't be resolved.

I'm not sure how serious this bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to options.ts.
  2. Notice the path argument of require.resolve.
  3. Go to the parent directory.
  4. Notice there is no file named framework-preset-angular.js.

Expected behavior
Should get an error when trying to build the Storybook.

System:

  • OS: MacOS
  • Device: Macbook Pro 2016
  • Browser: Chrome
  • Framework: Angular
  • Version: 5.1.9
@spenceryue
Copy link
Author

The files become *.js files after building I assume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants