Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Error "markdown-to-jsx: the first argument must be a string" #7596

Closed
1 of 2 tasks
shilman opened this issue Jul 29, 2019 · 1 comment
Closed
1 of 2 tasks

Addon-docs: Error "markdown-to-jsx: the first argument must be a string" #7596

shilman opened this issue Jul 29, 2019 · 1 comment
Labels
addon: docs bug
Milestone
5.2.0

Comments

@shilman
Copy link
Member

shilman commented Jul 29, 2019 •
edited

The logic for using non-string info/notes is broken!

  • Improve heuristic
  • Add test cases
@shilman shilman added this to the 5.2.0 milestone Jul 29, 2019
@shilman shilman mentioned this issue Jul 29, 2019
Merged
@shilman
Copy link
Member Author

shilman commented Jul 29, 2019

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.18 containing PR #7597 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 29, 2019
@shilman shilman mentioned this issue Jul 30, 2019
Closed
@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs bug
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@shilman