Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook webapp preview area is blank #836

Closed
shilman opened this issue Apr 15, 2017 · 10 comments
Closed

Storybook webapp preview area is blank #836

shilman opened this issue Apr 15, 2017 · 10 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by mnmtanish
Friday Aug 26, 2016 at 09:05 GMT
Originally opened as storybook-eol/react-native-storybook#63


The preview area is blank at the moment (as preview is done using simulators).

Options

  1. add a simple user guide whch asks users to run the simulator
  2. make it configurable with the addon api and let users decide
  3. make it configurable and then use it to add user guide by default
@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by arunoda
Friday Aug 26, 2016 at 10:24 GMT


We can that screenshot preview thing here. It will be pretty useful.

@shilman shilman added the bug label Apr 15, 2017
@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by mnmtanish
Monday Aug 29, 2016 at 06:16 GMT


Addon developers can use the addons API to set whatever they want there. We can include the screenshots addon by default as soon as it's ready.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by FaridSafi
Tuesday Sep 06, 2016 at 15:48 GMT


I suggest to allow to render a custom image/text as a preview for each story
Eg: displaying a mockup of the component to develop

Edit: I finally created an addon to display a mockup

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by elie222
Saturday Oct 15, 2016 at 22:52 GMT


I'm confused how Storybook is supposed to work for RN. I'm running the app on iOS simulator, and have gone to the storybook url in the browser, but i dont see any components. it's just an empty storybook

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by mnmtanish
Sunday Oct 16, 2016 at 08:27 GMT


Hi @elie222
We're still working on the preview area. Please start the iOS/Android simulator/emulator to check it out for now. Check this readme file and the screenshot in the Readme for more information.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by elie222
Sunday Oct 16, 2016 at 12:18 GMT


The entire storybook is blank for me. And when I start the app, I just see
my regular app running without anything Storybook related.

I've run: npm run storybook

And started my app, but the regular app just starts up.

On 16 October 2016 at 11:27, Muhammed Thanish notifications@github.com
wrote:

Hi @elie222 https://github.com/elie222
We're still working on the preview area. Please start the iOS/Android
simulator/emulator to check it out for now. Check this readme
https://github.com/kadirahq/react-native-storybook/blob/master/readme.md
file and the screenshot in the Readme for more information.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
storybook-eol/react-native-storybook#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC8oX_OOEKFJ32moW4I7yEzh0s73vEcEks5q0eAPgaJpZM4Jt4cG
.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by elie222
Sunday Oct 16, 2016 at 12:57 GMT


Ah, the issue may be that I'm using Exponent. Someone told me they got it running, but it turns out it wasn't with Exponent in the end.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by gourav-singhal
Thursday Mar 09, 2017 at 12:21 GMT


Hi,

Is this issue resolved ? I am still getting a blank left story board with no preview.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by Nasirilahi
Thursday Mar 16, 2017 at 17:02 GMT


gourav-singhal You will not be able to see preview in browser as it is mobile app so you will see storied in you simulator/device as you can see in the screenshot and in your browser you will be able to see only actions handlers. Also if you have run command react-native start then you will see only your project running so run npm run storybook command only to see you stories in you simulator/device.

@shilman
Copy link
Member Author

shilman commented Jun 23, 2017

This was fixed here: #1142

https://github.com/storybooks/storybook/issues/1125 will take a more awesome approach to this.

Closing this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant