Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IStory interface is not exported anymore #9041

Closed
andrei-ilyukovich opened this issue Dec 3, 2019 · 3 comments
Closed

IStory interface is not exported anymore #9041

andrei-ilyukovich opened this issue Dec 3, 2019 · 3 comments

Comments

@andrei-ilyukovich
Copy link

There was possibility to import IStory interface from "@storybook/angular" before (if I'm not mistaken it is still possible in v5.0.6). In the latest versions there is no such import available. It looks like proper replacement could be StoryFnAngularReturnType, but it is used internally and not exported from the root of "@storybook/angular" and only could be retrieved by
import { StoryFnAngularReturnType } from "@storybook/angular/dist/client/preview/types"; which is not a proper way.
Below is the code snippet where we used IStory before:

const wrap: Function = (templateFn) => (storyFn) => {
    const story: IStory = storyFn();
    return {
        ...story,
        template: templateFn(story.template)
    };
};
addDecorator(wrap((content) => `<sdo-storybook-settings></sdo-storybook-settings>${content}`));

System:
"@storybook/*": "5.2.4"

@stale
Copy link

stale bot commented Dec 24, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 24, 2019
@shilman
Copy link
Member

shilman commented Jan 21, 2020

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.8 containing PR #9097 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member

shilman commented Jan 23, 2020

¡Ay Caramba!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.1 containing PR #9097 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants