Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-docs] PropTable shows only default props in production #9784

Closed
iamshadmirza opened this issue Feb 7, 2020 · 4 comments
Closed

[addon-docs] PropTable shows only default props in production #9784

iamshadmirza opened this issue Feb 7, 2020 · 4 comments

Comments

@iamshadmirza
Copy link
Contributor

Describe the bug
Addon-docs PropTable is not working correctly in production. The table is correct in development but after deploying to Netlify, it shows only those props which are common to propTypes and defaultProps. Also, the description column shows unknown. The deployed site is here: https://rnds.netlify.com

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/iamshadmirza/react-native-design-system

There is no error log. StoryBook is compiling without error. The PropTable is not working as expected in production.

Expected behavior
https://github.com/iamshadmirza/react-native-design-system

Screenshots
This is in development:

Screenshot (64)

This is after deploying to Netlify or GitHub pages.

Screenshot (65)

Code snippets
To run storybook in development:

start-storybook -p 9001 -c .storybook -s .storybook/assets

To create build:

build-storybook -c .storybook -s .storybook/assets -o docs

Additional context
Modules used

{
    "@storybook/addon-actions": "^5.3.12",
    "@storybook/addon-docs": "^5.3.12",
    "@storybook/addon-knobs": "^5.3.12",
    "@storybook/react": "^5.3.12",
    "@storybook/theming": "^5.3.12",
}
@stale
Copy link

stale bot commented Feb 28, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@iamshadmirza
Copy link
Contributor Author

Any support on this?

@shilman
Copy link
Member

shilman commented Mar 4, 2020

I'm not seeing this on https://storybook-design-system.netlify.com/

@stale
Copy link

stale bot commented Mar 26, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants