Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upgrade from Angular 8 -> 9 with the Angular CLI due to zone.js dependency #9785

Closed
TheAngularGuy opened this issue Feb 7, 2020 · 3 comments

Comments

@TheAngularGuy
Copy link

Describe the bug
Upgrading from Angular 7 to Angular 8 via the CLI won't proceed due to @storybook/angular's zone.js peerDependency.

To Reproduce
ng update @angular/core @angular/cli -C

Output
Package "@storybook/angular" has an incompatible peer dependency to "zone.js" (requires "^0.8.29 || ^0.9.0", would install "0.10.2").

Expected behavior
The upgrade should complete.

System:

  • System:
    OS: Windows 10 10.0.17134
    CPU: (4) x64 Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
  • Binaries:
    Node: 12.14.1 - C:\Program Files\nodejs\node.EXE
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD
  • Browsers:
    Edge: 42.17134.1098.0
@gaetanmaisse
Copy link
Member

@TheAngularGuy which version of Storybook are you using? Because it should have been fixed with 3b84236 and released with Storybook 5.3.

@stale
Copy link

stale bot commented Mar 3, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 3, 2020
@stale
Copy link

stale bot commented Apr 2, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants