Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use hash routing instead of query string #9856

Closed
onigoetz opened this issue Feb 14, 2020 · 2 comments
Closed

Allow to use hash routing instead of query string #9856

onigoetz opened this issue Feb 14, 2020 · 2 comments

Comments

@onigoetz
Copy link

Is your feature request related to a problem? Please describe.
We use Jenkins to build all our artifacts and app, some of which use the HTMLPublisher Plugin that allows publishing a folder containing HTML pages and reports to easily access them with the builds.

Currently this plugin has a bug; when the url has a "path" query parameter, it redirects to that. so if my generated Storybook documentation is at : https://my-jenkins/myjob/master/report/index.html
Upon opening it; the url changes to https://my-jenkins/myjob/master/report/index.html?path=/link_to_storybook_page/link_to_storybook_item

Now if I were to refresh the page or open it in a different window. I get a 404. Because I get redirected to https://my-jenkins/link_to_storybook_page/link_to_storybook_item

Bug is documented here : https://issues.jenkins-ci.org/browse/JENKINS-61095

Describe the solution you'd like
Have the possibility to have URLs like https://my-jenkins/myjob/master/report/index.html#?path=/link_to_storybook_page/link_to_storybook_item would work around the issue I have.

Describe alternatives you've considered
I have raised an issue for the Jenkins plugin at https://issues.jenkins-ci.org/browse/JENKINS-61095 it would be great if they fixed it at their level.

Are you able to assist bring the feature to reality?
yes, if you point me to the direction where the routing is handled, I can make a PR, provide it as a coniguration option.

Additional context
N/A

@stale
Copy link

stale bot commented Mar 6, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants