Support webpack 3.0.0 #1410
Merged
Support webpack 3.0.0 #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the main webpack dependency will break for users using 3.0.0. See storybookjs#1371
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
=======================================
Coverage 14.35% 14.35%
=======================================
Files 201 201
Lines 4612 4612
Branches 499 499
=======================================
Hits 662 662
Misses 3522 3522
Partials 428 428Continue to review full report at Codecov.
|
|
Awesome! thank you @tarjei 👍 |
|
👍 any chance this will get into an official release soon? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the main webpack dependency will break for users using 3.0.0. See #1371
Issue:
#1371
What I did
I allowed for webpack 3.0.0.
How to test
Se #1371