Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nopreview vue #1504

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Fix nopreview vue #1504

merged 2 commits into from
Jul 22, 2017

Conversation

ndelangen
Copy link
Member

Issue:

What I did

Fixed a bug where initially no stories would appear to be displayed/loaded, and switching stories would not re-render.

screen shot 2017-07-22 at 00 28 32

The message now disappears switching stories / adding stories.

How to test

  • Run the Vue kitchen sink
  • Open url, without any parameters
  • The nopreview message should NOT show.

@ndelangen ndelangen added the vue label Jul 21, 2017
@ndelangen ndelangen added this to the v3.2.0 milestone Jul 21, 2017
@ndelangen ndelangen changed the base branch from master to release/3.2 July 21, 2017 22:38
@ndelangen ndelangen merged commit 958e5d8 into release/3.2 Jul 22, 2017
@ndelangen ndelangen deleted the fix-nopreview-vue branch July 22, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

Assignees
No one assigned
Labels
vue
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndelangen