New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-components: Dynamic source snippets #15337
Conversation
Adds dynamic source to the web-components 'framework' package.
Nx Cloud ReportCI ran the following commands for commit 9a5dccd. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
In https://github.com/storybookjs/storybook/blob/next/app/web-components/src/client/preview/render.ts#L24 you can see that the |
I dunno, might have to 🦆 type the return value of edit: Then again, as long as the return value is a |
Question re: decorators for the Storybook team... Is is possible to resolve the root/origin story, so that the source here comes from that no matter the order in which the decorator is applied? Right now, it has to go first, or it will render the decorator code only, which isn't too bad, but would be nice not to require. |
Tried to test this locally but got
🤷♂️ |
Split config functions into separate modules Add type and language to docs.source
@bennypowers doesn't seem to be working for me. what am i missing? |
@shilman I think this is intended behaviour. storybook/examples/web-components-kitchen-sink/src/components/sb-button.stories.ts Lines 20 to 26 in 209cdac
TL;DR: only changes to if you change those lines to the following (and similarly added const Template: Story<SbButton> = ({ primary, backgroundColor, size, label }) =>
html`<sb-button
?primary="${primary}"
size="${size}"
label="${label}"
background-color="${backgroundColor}"
></sb-button>`; I've made those changes and updated this PR, so once CI is done you should see it reflected on the page NOTE: there appears to be a problem with the argTypes derived from the manifest for the |
@bennypowers i don't know enough about web-components to know what is expected behavior, but it looks off to me. naively, i would expect it to produce source strings like:
|
The purpose here is to output html that someone could copy and paste into any document, rather than, say, a lit-html template javascript source.
web components are one thing, and lit-html is another so while it's true that storybook lumps "web components" in with "frameworks" by parsing lit-html templates, that's really just a bone that storybook tosses to story authors to make it easier to write stories. lit-html !== web components, not by a long shot, but the one thing each and every web component has in common is HTML and the DOM |
isn't it strange, though, to see a picture of a large, red button that says "hahaha", and paste a snippet that results in a small, blue button that says "Button" (or whatever the default label is)? i get the difference between lit-html and plain html. i think this examples illustrates part of the reason @brion-fuller and @gaetanmaisse have been pushing for a |
i was referring to the behavior before your last set of changes, which you described as expected. are you saying that people should only use lit-html attributes, not properties, if they want their snippets to reflect what's being rendered in the story? i could be ok with that, i just want to understand the limitations of this approach, since changing them from properties to attributes feels like a workaround. |
Yes*, I'm saying that this should be the "best practice" recommendation: const Template: Story<SbButton> = ({ primary, backgroundColor, size, label }) =>
html`<sb-button
?primary="${primary}"
size="${ifDefined(size)}"
label="${ifDefined(label)}"
background-color="${ifDefined(backgroundColor)}"
></sb-button>`; Which is in line with the general community standards - accept attributes if you can, properties for complex data in lieu of children. Components that follow those recommendations are more easily styled in Certainly here, where the goal is a copy-able snippet, content is king, so attrs should be the norm. *Edit: It's hard to say "only" since I can't cover every use of every HTML element, but most users will probably want to do like ☝️ in most cases. |
When I copied this approach locally, I saw what I expected from the output of the snippet, HTML that I can paste into another page and it just works. I’d prefer if it were It is possible that I missed the HTML updating with the Controls, but it is HTML that I’d want here so as not to require my consumers to work in my context, be that lit-html, JS string, etc. Assuming that’s true, I can’t fully check while remote from the beach this week, I’m a huge fan of this addition! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @bennypowers @Westbrook. I agree it's a wonderful addition and I'm really excited about getting it merged!
I'd love it if @gaetanmaisse or @brion-fuller can take a look.
} | ||
|
||
export function sourceDecorator(storyFn: StoryFn, context: StoryContext) { | ||
const story = storyFn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do others feel about context.originalStoryFn
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my thoughts on the matter: #14652 (comment)
Since this is all brand new in web-components, we can make it opt-out OR opt-in, depending on how you guys feel. I believe it's safer to include the decorators by default and allow users to opt-out of the decorators. In the React world, it's quite common for stories to rely on the decorators to provide context to render properly. But I'll defer to your collective judgment for what's best in the web-components world.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Westbrook can you elaborate on the case, both ways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I’m less worried as long as it’s configurable. However, for my library I use a very Storybook custom decorator to control theme color/scale/direction in a way that you wouldn’t want to require a copy/paster to clean up after the fact. storyFn()
leaves all of the decorator code whereas without it you copy just the component under demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bennypowers @Westbrook WDYT about adding configuration in this PR? i'm afraid if it doesn't get done now it will slip through the cracks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to put this in i'm just unfamiliar with the relevant apis.
is it just
const story = context.stripDecorators ? context.originalStoryFn() : storyFn():
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it consistent with React:
const story = context?.parameters.docs?.source?.excludeDecorators
? context.originalStoryFn(context.args)
: storyFn();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added with unit tests, thanks
commit 6ddfbc31cfa03444d34256da1fc715c81744ff3a Merge: 2efd8b17db 58a660a39b Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Thu Jul 15 17:26:27 2021 +0100 Merge pull request #15594 from doutori/feature/add-unittest-snipet-for-preact [Documentation] Add an unit test snipet for preact commit 2efd8b17dbeb1d170c2bd58b7abff659ce1bcfae Author: Michael Shilman <michael@lab80.co> Date: Thu Jul 15 20:56:24 2021 +0800 v6.4.0-alpha.17 commit 20105ab0b502608bacc969d5c78e69085a315b01 Author: Michael Shilman <michael@lab80.co> Date: Thu Jul 15 15:13:10 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.17 [ci skip] commit df749c6834b9785ac0fc80ec460a1989679f1363 Author: Michael Shilman <michael@lab80.co> Date: Thu Jul 15 15:12:54 2021 +0800 6.4.0-alpha.17 changelog commit 22be2a44ab7eccc29b1dcf042b6b85fc2fea76ac Merge: e9d7d75a3c 8155e2b7a3 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Thu Jul 15 15:10:04 2021 +0800 Merge pull request #15592 from storybookjs/feat/export-base-story-types Types: Export BaseStoryFn and BaseStoryObject commit 58a660a39b71d783ae8f3ec5b0145a47bbeffe1d Author: Hiroaki Sasaki <sasaki-hiroaki@dmm.com> Date: Thu Jul 15 13:04:24 2021 +0900 Add an unit test snipet of preact commit 8155e2b7a38dd54785c9161f46fc5e90dfa463a7 Author: Yann Braga <yannbf@gmail.com> Date: Thu Jul 15 01:14:00 2021 +0200 types: export BaseStoryFn and BaseStoryObject These types could be needed by other libraries in order to do proper inferring or typecasting commit e9d7d75a3c78eaa0302fb72b1654bb88e65b472a Merge: dc390b844d d787f584e8 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Wed Jul 14 16:49:03 2021 +0100 Merge pull request #15528 from storybookjs/chore_updates_build_pages_docs Chore: (Docs) Polish the Workflows-Build pages documentation commit d787f584e875fa04e18a5fe44084f1c609626b58 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Wed Jul 14 12:19:44 2021 +0800 Update docs/workflows/build-pages-with-storybook.md commit dc390b844d3f510e2e1474c894fb1d7f32037f7a Merge: 6846b6454a f5295a299e Author: Michael Shilman <shilman@users.noreply.github.com> Date: Wed Jul 14 12:11:39 2021 +0800 Merge pull request #14439 from bart-krakowski/colorpalette_transparency_grid Addon-docs: Add transparency support to color swatch commit f5295a299e76241fe354935f2ca9fc79b6cd27a8 Author: Bartłomiej Krakowski <48633090+bart-krakowski@users.noreply.github.com> Date: Tue Jul 13 22:21:24 2021 +0200 fix: added the background-clip property commit 6846b6454a33f1e507b076eff104ae1d634aaa41 Merge: 29b50a7d79 f9b837e313 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Tue Jul 13 20:37:36 2021 +0100 Merge pull request #15568 from storybookjs/fix_toolbars_docs Chore:(Docs) Fix toolbar docs with better examples and minor polish commit f9b837e3131b879c440ff1d7ca32157ef5a8f2e7 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Tue Jul 13 20:14:31 2021 +0100 fix toolbar docs with better examples and minor polish commit 0f5569eb0fb1ee0d59465eee96e5f894ca93d343 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Tue Jul 13 19:20:57 2021 +0100 polish documentation based on feedback commit 29b50a7d791eaa20bf5f8aa0b8b456638e9f82bb Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 23:42:30 2021 +0800 6.4.0-alpha.16 next.json version file commit 8a8a4e68d3fd9d7608f2d4c66333fbebcbff8dd4 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 23:40:01 2021 +0800 Update git head to 6.4.0-alpha.16, update yarn.lock commit 3afa39c64e2efe01e567ce8946e80586d77a8b73 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 23:34:17 2021 +0800 v6.4.0-alpha.16 commit a0c8f43e10f1949d80114b6f1e875865924057ce Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 23:19:25 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.16 [ci skip] commit 57c2b6b716af00e3aea206c2cf6c7888bd2e223c Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 23:19:00 2021 +0800 6.4.0-alpha.16 changelog commit 8f57aa86fb9fdeed369711db5b2d05fc381b1754 Merge: c399d5e761 ced6aba1dc Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 23:13:05 2021 +0800 Merge pull request #15563 from storybookjs/fix/angular-actions-argtype Angular: Fix actions argType auto generation commit c399d5e76119d853284d5c402578cecbc0f0682b Merge: 783cfd3fd9 6db035bfdf Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 23:11:23 2021 +0800 Merge pull request #13711 from storybookjs/feature/remove-animation-backgrounds-a11y Addon-backgrounds: Respect user's reduced motion settings commit 783cfd3fd99cc7169dce80d1da2fcbf09d042caf Merge: c88e0aa1b5 0a65ecbca8 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 23:01:39 2021 +0800 Merge pull request #15561 from neilbryson/fix_broken_link [Documentation : Configure Addons] fix broken link to withRoundTrip example commit ced6aba1dcafbd0f68222c5c068898a2678209b4 Author: Yann Braga <yannbf@gmail.com> Date: Tue Jul 13 16:18:20 2021 +0200 fix(angular): fix actions argType auto generation - The order in the sections matters because properties are overriden commit c88e0aa1b5bba8f3116eed3bd897b607057b632e Merge: 085e86c74b 07c3053e11 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 22:03:02 2021 +0800 Merge pull request #15558 from storybookjs/feat/csf3-types CSF: Add CSF3 typings commit 07c3053e1155b46510a784568dcd76863ff8b52b Author: Yann Braga <yannbf@gmail.com> Date: Tue Jul 13 11:01:18 2021 +0200 feat(types): make meta title optional commit 0b850ae52fd48dc79bccc2a5c5ada4bb83d28267 Author: Yann Braga <yannbf@gmail.com> Date: Tue Jul 13 10:42:00 2021 +0200 chore: use story types in CSF3 example commit 70888b3747c6d1d270f53a44183df389a029a1e7 Author: Yann Braga <yannbf@gmail.com> Date: Tue Jul 13 10:34:27 2021 +0200 Update lib/addons/src/types.ts commit 085e86c74b52cdf474aaf60167ae05674b2b0d4d Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:33:59 2021 +0800 6.4.0-alpha.15 next.json version file commit c89b2b03eceb60b08eb2543ac94cbfecd5fbf0cc Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:30:50 2021 +0800 Update git head to 6.4.0-alpha.15, update yarn.lock commit 9385c454a7470957b8317b17264ca951d212ff1a Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:25:02 2021 +0800 v6.4.0-alpha.15 commit 525179851d4b5cf8b298aa00927d8edc0873fc22 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:12:23 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.15 [ci skip] commit b606f0d505087eb06d9bfe4340e2ee281480d6e2 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:11:46 2021 +0800 6.4.0-alpha.15 changelog commit b00cb054dfd4972296e85d1b798b7ad5a04fbea5 Merge: 49e132769c 75bf6ec05a Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 10:10:04 2021 +0800 Merge pull request #15557 from mayank99/patch-1 Update MIGRATION.md to clarify default values inference commit 75bf6ec05a976aeb081be665f40a28a88a7f2752 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 13 10:09:15 2021 +0800 Fix TOC commit 42fca03bc45d3fe573b6a57f2d83242fcbfdb261 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 09:57:25 2021 +0800 Update lib/addons/src/types.ts commit 49e132769cc0951cc14e5603226aa38c4660d989 Merge: 5085073c7c 2ac6d8a591 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 09:54:12 2021 +0800 Merge pull request #15549 from storybookjs/fix/controls-color-matcher Controls: Fix color matching behavior for non-string types commit 5085073c7ccf9a69f0e6b13655344bb72cc40b4c Merge: e7a0016114 c3ea5c7de1 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 09:49:03 2021 +0800 Merge pull request #15556 from storybookjs/fix-ci Build: Fix `publish` step on CircleCI commit e7a00161149a1abae0e252b26490889d14f93215 Merge: 9ab0618853 8ad7c83b59 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 13 09:45:04 2021 +0800 Merge pull request #12155 from mattdarveniza/mdx-argstable-stories Add example codesnippet for using ArgsTable with stories commit 0a65ecbca8afe90e2d2f7852703b0a0653f9ead7 Author: Neil Bryson Cargamento <neilbryson@users.noreply.github.com> Date: Tue Jul 13 09:41:08 2021 +0800 fix broken link to withRoundTrip example commit 8ad7c83b59baccf7e69c75e9726025fb0ec0a4d2 Merge: 63555fc13e 9ab0618853 Author: Matt Darveniza <matt.darveniza@biarri.com> Date: Tue Jul 13 10:49:06 2021 +1000 Merge branch 'next' of https://github.com/storybookjs/storybook into mdx-argstable-stories commit 63555fc13e4f55337414de93ad92756379eb7c0d Author: Matt Darveniza <matt.darveniza@biarri.com> Date: Tue Jul 13 10:46:57 2021 +1000 fix import in example commit 80405894975c1099796dc5a6f7125de1ba2f328e Author: Yann Braga <yannbf@gmail.com> Date: Tue Jul 13 01:02:56 2021 +0200 feat(types): add CSF3 typings - Support object notation - Render function - Play function commit c3ea5c7de1312ca89a53cee0dd03643db13d17c6 Author: Yann Braga <yannbf@gmail.com> Date: Mon Jul 12 23:48:16 2021 +0200 fix(angular): update argTypes test snapshots - following the changes of ff483f6028a commit ff483f6028a376a391613a7f4b4b785531679782 Author: Yann Braga <yannbf@gmail.com> Date: Mon Jul 12 23:12:23 2021 +0200 fix(angular): extract type from compodoc propertiesClass - An update has been released in compodoc 1.1.12 which changed how the componentData is filled. Now the propertiesClass is filled together with inputClass so the check has to be updated commit 983ce9c41040213b0f6da31eea7b4d9a9b5e50e4 Author: Gaëtan Maisse <gaetanmaisse@gmail.com> Date: Mon Jul 12 21:38:33 2021 +0200 chore: improve the way Cypress records are handled as CircleCI artefacts commit c9552b6c6028b0067937762e3a7be087dfc06a38 Author: Mayank <9084735+mayank99@users.noreply.github.com> Date: Mon Jul 12 14:56:09 2021 -0400 Update MIGRATION.md commit 17e026fa9d610c8df485530122a0619f8b9504fc Author: Gaëtan Maisse <gaetanmaisse@gmail.com> Date: Mon Jul 12 20:49:55 2021 +0200 chore: fix Verdaccio config for addon-measure commit ce37c7ece665ac7e171b490ed455a89ecd1930c2 Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Mon Jul 12 20:35:49 2021 +0200 revert: removed isTransparent prop commit 6db035bfdfa7fbf30e3c06b8fe9f659e0fa5e23e Author: Yann Braga <yannbf@gmail.com> Date: Fri Jan 22 18:31:20 2021 +0100 feat(addon-backgrounds): reduced motion disables transition - addon backgrounds should respect the user's configuration - so it disables transition transition animation when requested commit 9ab061885383aa87432be284b3b1e352cccb4281 Merge: e4e32bb183 b3274336c3 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 12 23:39:17 2021 +0800 Merge pull request #15546 from storybookjs/examples/add-no-manager-cache Examples: Add no-manager-cache to all examples commit e4e32bb183785e52c3b68d77f11b2f565574a697 Merge: 90895b20e4 7dc255b7e9 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 12 23:39:00 2021 +0800 Merge pull request #15529 from storybookjs/docs/document-webpack-instance Document webpack instance in presets commit 90895b20e4de23ce4692188baa1d1cf0104aed86 Merge: e8e4ca7709 c65d1c2cda Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Mon Jul 12 15:23:55 2021 +0100 Merge pull request #15550 from przmv/patch-1 Adding information on Angular app creation commit c65d1c2cda27f45d2dbcf67c6966638be24cf4c1 Author: Petr Razumov <p@rzmv.cc> Date: Mon Jul 12 13:05:15 2021 +0300 Adding information on Angular app creation commit e8e4ca7709d975150fa48d7dad5db4e01ea6c9c5 Merge: 01555f7022 a46a05642e Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 12 11:49:19 2021 +0800 Merge pull request #15449 from Nazeeh21/my-first-storybook-contribution UI: Fix toggle button for custom theming commit a46a05642e93a8a64eeb6b55cf7818d25ceb7b22 Merge: 1e5424a683 01555f7022 Author: Michael Shilman <michael@lab80.co> Date: Mon Jul 12 11:39:09 2021 +0800 Merge branch 'next' into pr/15449 commit 01555f702294acfa6a39b84055d4021200f074af Merge: 79950a9b5a 64e99bcb13 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 12 10:08:45 2021 +0800 Merge pull request #15540 from koba04/patch-3 docs: update the command to update the snapshot commit 79950a9b5a97ed9683270b93a310397f8c4056b9 Merge: 1bd9907094 a0abeb34d7 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 12 10:05:57 2021 +0800 Merge pull request #15533 from storybookjs/15510-example-mdx-embed-object-story Official-storybook: Add example of embedding story object in MDX commit 2ac6d8a591c0aeaca09123910b92161a308b7d44 Author: Yann Braga <yannbf@gmail.com> Date: Sun Jul 11 20:44:36 2021 +0200 fix(controls): use correct assertion for color type commit 1bd990709477ba2bbe37514820221ff16cc060cf Author: Michael Shilman <michael@lab80.co> Date: Sun Jul 11 03:18:32 2021 +0800 6.4.0-alpha.14 next.json version file commit 6daa716e93f58367f5b8be69e84a9da2333ed71b Author: Michael Shilman <michael@lab80.co> Date: Sun Jul 11 03:15:36 2021 +0800 Update git head to 6.4.0-alpha.14, update yarn.lock commit d3f8b5119b70ecf23ef2006b58034292eab3726e Author: Michael Shilman <michael@lab80.co> Date: Sun Jul 11 03:10:46 2021 +0800 v6.4.0-alpha.14 commit 4d4fe97cab296153bf3e0786d478e9e47a7b6796 Author: Michael Shilman <michael@lab80.co> Date: Sun Jul 11 03:01:43 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.14 [ci skip] commit f18ac7ce83fd4b38a42827e89bd89fc849985ba6 Author: Michael Shilman <michael@lab80.co> Date: Sun Jul 11 03:01:21 2021 +0800 6.4.0-alpha.14 changelog commit 31e3ad8b816f8a0686d616309e100a7d0f3bad72 Merge: f6c296c6bd 9a5dccde24 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sun Jul 11 02:59:45 2021 +0800 Merge pull request #15337 from bennypowers/patch-1 Web-components: Dynamic source snippets commit 9a5dccde24cfb9323b2e107d9abdef8168449e55 Author: Benny Powers <web@bennypowers.com> Date: Sat Jul 10 21:31:23 2021 +0300 fix(addons): webcomponents excludeDecorators commit b3274336c344e8060857d379e0dea708b76159af Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 10 22:04:54 2021 +0800 Examples: Add no-manager-cache to all examples commit f6c296c6bd860c0bcc961b2d8475910d61747713 Merge: 1dccc275b1 c165b36b7e Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 10 20:03:23 2021 +0800 Merge pull request #15545 from storybookjs/bring-mesure-addon-to-monorepo Essentials: Add measure addon to monorepo commit c165b36b7ea53aae46c9fa4464d5e411e624f80d Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 10 19:26:27 2021 +0800 Add measure to package/nx/workspace.json & update snapshots commit 080f1b2d9bbdef7714c5507943c08acf071dcd76 Author: winkerVSbecks <varunvachhar@gmail.com> Date: Fri Jul 9 18:13:30 2021 -0400 Add measure addon to monorepo and update version to match other addons commit 64e99bcb13cc33e34ce186d6d9cf83627f26620c Author: Toru Kobayashi <koba0004@gmail.com> Date: Sat Jul 10 01:12:18 2021 +0900 docs: update the command to update the snapshot commit 1e5424a683348a659528f727861c3b85a1d59f97 Merge: 43224dbd27 1dccc275b1 Author: Nazeeh Vahora <nazeehvahora.786@gmail.com> Date: Fri Jul 9 13:56:12 2021 +0530 Merge branch 'storybookjs:next' into my-first-storybook-contribution commit 43224dbd27e2ab8f217244e4ff952657c9a11d19 Author: Nazeeh2000 <nazeehvahora.786@gmail.com> Date: Fri Jul 9 13:54:31 2021 +0530 Implement suggested changes commit 1dccc275b13d39f4f933523496031f34eea1ac96 Merge: dc78ef424a b74d49ddf8 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 9 16:17:50 2021 +0800 Merge pull request #15535 from evancharlton/patch-1 chore: Fix a typo commit b74d49ddf8a9675c98eadab88bba9a2e35d39b30 Author: Evan Charlton <evancharlton@microsoft.com> Date: Fri Jul 9 09:59:44 2021 +0200 chore: Fix a typo Just a small misspelling: `serverely` -> `severely` commit dc78ef424a117fa3748613921b00ce07b3a1e484 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 15:41:35 2021 +0800 6.4.0-alpha.13 next.json version file commit ebb05e38cb0aa22874c16099246d8dcffe200392 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 15:38:51 2021 +0800 Update git head to 6.4.0-alpha.13, update yarn.lock commit c3462074cbdd21af71e115d90993ac5aa801f681 Merge: a61c50e695 70d04492b6 Author: Nazeeh Vahora <nazeehvahora.786@gmail.com> Date: Fri Jul 9 13:01:47 2021 +0530 Merge branch 'storybookjs:next' into my-first-storybook-contribution commit 70d04492b677c52c518b1b9591e382ba57484042 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 15:31:29 2021 +0800 v6.4.0-alpha.13 commit 15814517e0f20b06bb5bdf50a4962b2b5db110de Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 15:21:05 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.13 [ci skip] commit 11269f4ef772a30182eadbfeccbdb42b6999d544 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 15:20:38 2021 +0800 6.4.0-alpha.13 changelog commit cfc23ecd4dd73d513b1be3e9c307fb4e6cf074f9 Merge: c884f2ef6c ca14dcfff3 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 9 15:19:00 2021 +0800 Merge pull request #15526 from storybookjs/bring-outline-addons-to-monorepo Essentials: Add outline addon to monorepo commit c884f2ef6cc72fb14a0711f1ae5768c8a829cd41 Merge: a24616a7d3 9db2e2b1ab Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 9 14:51:47 2021 +0800 Merge pull request #15501 from dexster/Allow_duplicate_stories Addon-docs/Angular: Add unique id to Angular stories commit a0abeb34d7d6227d32f27f7aa3e8f2a5dee35fcc Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 14:35:52 2021 +0800 Official-storybook: Add example of embedding story object in MDX commit a24616a7d35f644c5fdc1e8fe6ef5251b187d38f Merge: 4ddb363221 0d54d345a8 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 9 14:21:05 2021 +0800 Merge pull request #15527 from dexster/Composition_order Composition: Fix refs ordering commit 0d54d345a8a6f5bd586c6f6a80fb1fa8b4215a16 Author: Brett Upton <brett.upton@standardbank.co.za> Date: Fri Jul 9 08:06:31 2021 +0200 Changed composition titles commit 12a34928933dd5b25aceb26093cf87d1f38ecd9f Author: Brett Upton <brett.upton@standardbank.co.za> Date: Fri Jul 9 08:02:20 2021 +0200 Moved composition into an existing example project commit ca14dcfff3620ca4c05579ff48817e52a9ffa3ef Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 12:44:18 2021 +0800 Update snapshots commit a9e45162312365ce13af42917e76cdfa122e302f Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 11:47:54 2021 +0800 Add addon-outline to yarn/nx bureaucracy commit 7dc255b7e99f2f1837c61efdad5e766e4254ee98 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 9 11:11:31 2021 +0800 Document webpack instance in presets commit 8c1a3e6c97bcb7e0d325d03749bddd177329d052 Author: Brett Upton <brett.upton@standardbank.co.za> Date: Fri Jul 9 00:22:20 2021 +0200 Fix Storybook composition order commit 4ddb36322146fe80f9d55d50cf53eb66a7359c28 Merge: f2b55b6278 eb72096246 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Thu Jul 8 23:22:01 2021 +0100 Merge pull request #15478 from kwhsiung/patch-1 docs: add missing space commit da46fc4c2b5b0cc11c23c49b6a37783eb9b8a0b8 Author: Brett Upton <brett.upton@standardbank.co.za> Date: Fri Jul 9 00:09:05 2021 +0200 Fix Storybook composition order commit 77d0ee813f0d3506dbc7d820de31520861a086f4 Author: winkerVSbecks <varunvachhar@gmail.com> Date: Thu Jul 8 18:01:50 2021 -0400 Add outline addon to monorepo and rename package to @storybook/addon-outline commit e58e670f85c5dafb9a3955449e7ad2eae304f3aa Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Thu Jul 8 22:46:28 2021 +0100 msw addon documentation commit f2b55b6278c3207150867382a2a3ffc661f95610 Merge: f605419d23 f7d34723b8 Author: Gaëtan Maisse <gaetanmaisse@gmail.com> Date: Thu Jul 8 19:22:29 2021 +0200 Merge pull request #15523 from oscard0m/bump-setup-node-version-to-v2 Build: Fix cache setup in GitHub Actions workflow commit a1d0785937aa528c3037980c997025df4a1805cb Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Jul 8 19:13:01 2021 +0200 fix: removed unused props commit 8f2e20948b04703324635a8cec5f7af3a8686869 Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Jul 8 19:04:05 2021 +0200 fix: moved background pattern to parent commit f7d34723b88e9dbe938ee554a1c3de653832e15b Author: Oscar Dominguez <dominguez.celada@gmail.com> Date: Thu Jul 8 18:35:14 2021 +0200 ci(workflow): moved up acions/checkout step in 'test-unit.yml' commit 2c47a6e29aebdaf229c00577db6625b12c0b60a5 Author: Benny Powers <web@bennypowers.com> Date: Thu Jul 8 19:34:58 2021 +0300 docs(web-components): set attributes in example story commit f37c15c8de212b435040049644d26efab1c17da5 Author: Oscar Dominguez <dominguez.celada@gmail.com> Date: Thu Jul 8 18:33:34 2021 +0200 ci(workflow): bump setup-node to v2 in 'tests-unit.yml' commit 5590c2ce3c8420f88ea0c7ed26b2f677bd4180ef Merge: 2da73c28d9 726b124ac4 Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Jul 8 18:02:00 2021 +0200 Merge branch 'colorpalette_transparency_grid' of github.com:bart-krakowski/storybook into colorpalette_transparency_grid commit 2da73c28d9c2f11a8091876a1644905d0d6dcabe Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Jul 8 17:55:43 2021 +0200 fix: changed pattern in the background and updated examples of usage commit 726b124ac43c626e95a573e685872968d397641d Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Jul 8 17:55:43 2021 +0200 fix: change pattern in the background and examples examples of usage commit f605419d23c24072bbdefd9b376e0efedaf32bfe Author: Michael Shilman <michael@lab80.co> Date: Thu Jul 8 23:07:49 2021 +0800 6.3.4 changelog commit 0448db25a25e4d16da34691a421fe527dcd5dde5 Author: Michael Shilman <michael@lab80.co> Date: Thu Jul 8 10:46:24 2021 +0800 6.3.3 changelog commit 6873d3589a921752c9e39ad6d7eaffc432f2b159 Merge: 580522dd83 946b4145fc Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Wed Jul 7 14:41:09 2021 +0100 Merge pull request #15504 from eins78/patch-1 docs: fix typo in snippet storybook-preview-configure-globaltypes.js.mdx commit 580522dd834f1126a8c8f90f54ae9d9af5d8adc2 Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 18:23:21 2021 +0800 6.4.0-alpha.12 next.json version file commit cd98b1cc834bace6603180c62d4a0380a7bc07f6 Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 18:17:06 2021 +0800 Update git head to 6.4.0-alpha.12, update yarn.lock commit 417958f6d40b4ac7d361c706d9b96dd4123231cd Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 18:11:49 2021 +0800 v6.4.0-alpha.12 commit 0f8236dd2144927656281a217e376eeca3a835ba Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 18:00:38 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.12 [ci skip] commit f936e8f27b56d195872d429a786da13403de38b0 Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 18:00:19 2021 +0800 6.4.0-alpha.12 changelog commit d1cb1697e857371e5a76e18e000c93bba85a2393 Merge: 0589f5b0df 67ee40bbbd Author: Michael Shilman <shilman@users.noreply.github.com> Date: Wed Jul 7 17:52:30 2021 +0800 Merge pull request #15280 from storybookjs/angular/ngcc-example Angular: Make Ivy work by default in the angular-cli example commit 0589f5b0df912e547aefbe240f6737294034617c Merge: d139f758d4 9389325c80 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Wed Jul 7 17:46:39 2021 +0800 Merge pull request #15483 from storybookjs/fix/15227-storybook-hangs-on-angular Webpack5: Quit process after finishing a static build commit 946b4145fc618ac260165ede13e6f67e16a059be Author: Max Albrecht <max.albrecht@zhdk.ch> Date: Wed Jul 7 10:29:13 2021 +0200 docs: fix typo in snippet storybook-preview-configure-globaltypes.js.mdx commit 9389325c80373d9cd96c2845d39e0b46ba2a7b16 Author: Juho Vepsäläinen <bebraw@gmail.com> Date: Wed Jul 7 10:22:06 2021 +0300 fix: Remember to close webpack compiler It looks like this is the right way to go instead of `process.exit`. commit 9db2e2b1aba264ed7342e40de79e3a1fc9c978e5 Author: Brett Upton <brett.upton@standardbank.co.za> Date: Wed Jul 7 09:18:39 2021 +0200 Added unique id to stories commit d139f758d4586d720b64bff832fa6c01b33440ae Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 11:30:30 2021 +0800 Cleanup commit 4166959e44577a21e8dcef409893144a096d294e Merge: 52064d9da8 fd563b423b Author: Michael Shilman <shilman@users.noreply.github.com> Date: Wed Jul 7 09:44:46 2021 +0800 Merge pull request #15497 from storybookjs/fix/a11y-package-readme Addon-a11y: Fix package.json README link commit fd563b423b9262685403529252dbac54e4dcdb82 Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 09:24:50 2021 +0800 Update master => main in package.json commit 8bd127589786de672dec5bfc15a1fa817d675d47 Author: Michael Shilman <michael@lab80.co> Date: Wed Jul 7 09:24:28 2021 +0800 Addon-a11y: Fix package.json README link commit 52064d9da88ecc8af72eddc85091e0ee745b70d0 Merge: b6bf34a123 0453d31fc2 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Tue Jul 6 20:54:08 2021 +0100 Merge pull request #15496 from storybookjs/fix_theming_docs Chore: (Docs) Minor adjustments to the theming docs commit 0453d31fc22fa55d0862bd661f28add3a3a1333b Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Tue Jul 6 20:41:47 2021 +0100 minor adjustments to the theming docs commit b6bf34a123ed686cfbc9b594f7de9ee1bbf9b870 Merge: 52623ee4af 799da77e7f Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 6 23:55:42 2021 +0800 Merge pull request #15489 from storybookjs/fix-official-storybook-locale-previous-shortcut fix: shortcut for navigating to previous language in official-storybook example commit 67ee40bbbd188d0cf449df8e043441411d8039ff Author: ThibaudAv <thibaud.avenier@gmail.com> Date: Thu Jun 17 13:57:44 2021 +0200 chore(angular): add ngcc postinstall for angular-cli example change all angular storyshot because is now generated with ivy 🤔 commit e2d34eac363e13d981f52690e0b1e750d674fa64 Author: Benny Powers <web@bennypowers.com> Date: Tue Jul 6 15:24:30 2021 +0300 style(addons): remove null check commit e395fff381027b2f3f74fc6ed25bb637dee27800 Author: Benny Powers <web@bennypowers.com> Date: Tue Jul 6 15:14:31 2021 +0300 fix(addons): webcomponents transformSource commit 52623ee4af96e6085141b42d06b618b9d2d103bf Merge: 76d155ee35 45ddb57dea Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 6 20:00:23 2021 +0800 Merge pull request #7848 from storybookjs/tech/add-docs-to-standalone Addon-docs: Add docs to standalone example commit 45ddb57dea82bc397349ade248813afb3f72516f Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 6 19:15:22 2021 +0800 Update yarn.lock commit 7fc90b05eb92fe73a079551e6cf6b40ef3a7809f Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 6 19:11:13 2021 +0800 Update DocsPage demo to latest commit 2a11c562c2941579f93c9655ce91b5b08b41bbd8 Merge: cdaf6f049f 76d155ee35 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 6 19:00:41 2021 +0800 Merge branch 'next' into tech/add-docs-to-standalone commit 76d155ee35dcd2a2fcf1115c3c8481b0e6f2c60f Merge: 209cdac1b7 5347593f78 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 6 18:32:12 2021 +0800 Merge pull request #15491 from stefan-schweiger/15490-numeric-default-value Addon-docs/Angular: Fix numeric args default value handling commit 65e7803c3dd0922f7304bc9eee5e2aafaf509a2c Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 6 18:09:59 2021 +0800 Fix jest with lit-html ESM commit 3fd64f92fb6bccdbeecaed5569b08b900ddd78d2 Merge: d1039bc2e3 209cdac1b7 Author: Michael Shilman <michael@lab80.co> Date: Tue Jul 6 17:15:01 2021 +0800 Merge branch 'next' into pr/15337 commit 5347593f78cd54efd521b8250319534a4b2adc2f Author: stefan-schweiger <staeff@me.com> Date: Tue Jul 6 11:05:34 2021 +0200 Fixed numeric default value not working correctly commit 209cdac1b76d263056561e23729f62c949b42532 Merge: 606327e3cc e673030782 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Tue Jul 6 09:58:56 2021 +0800 Merge pull request #15470 from storybookjs/chore_loader_docs_updates Chore: (Docs) Updates the loader docs commit 799da77e7f1fc6cdf89334a60ff653b8b57edb84 Author: Deen Denno <darleendenno@gmail.com> Date: Mon Jul 5 18:01:56 2021 -0500 fix: shortcut for navigating to previous language in official-storybook example commit 606327e3cc35ba82da3473879128d079fd91c261 Merge: 818ea94fc5 40c5f66953 Author: Gaëtan Maisse <gaetanmaisse@gmail.com> Date: Mon Jul 5 20:26:11 2021 +0200 Merge pull request #15480 from oscard0m/add-cache-to-node-workflows Build: Update Yarn cache setup in GitHub Actions workflow commit e67303078293cbe21ac58e3fca75f7037bfced95 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Mon Jul 5 19:19:35 2021 +0100 address feedback commit 40c5f6695359dd7ca11ea0f0e7c18ef5f93c6716 Author: Oscar Dominguez <dominguez.celada@gmail.com> Date: Mon Jul 5 13:29:11 2021 +0200 ci(workflow): remove previous cache step commit 4fc9204e7a616107d72b68efab87d6e523dcb9fa Author: Oscar Dominguez <dominguez.celada@gmail.com> Date: Mon Jul 5 13:27:25 2021 +0200 fix(workflow): this workflow uses yarn cache commit 4e1bd0decd8afe545ace9202073168ec21dade17 Author: Juho Vepsäläinen <bebraw@gmail.com> Date: Mon Jul 5 14:27:02 2021 +0300 fix(angular): Quit process after finishing a static build I don't understand why `process.exit` is needed for this particular case but it seems to fix the issue. In order to be more safe, I also added a `try`/`catch` and in my own testing that caught a ngcc locking issue I would have missed otherwise. Closes storybookjs#15227. commit 818ea94fc540ea12d90a076dd542a0cf7545e0db Merge: 4bd2fc9b06 790dd94c24 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Mon Jul 5 18:16:57 2021 +0800 Merge pull request #15482 from storybookjs/docs/clarify-webpack5-migration Migration: Add webpack@5 hoisting instructions commit 790dd94c241a7a4a344a0da06e2db689980deceb Author: Michael Shilman <michael@lab80.co> Date: Mon Jul 5 18:15:49 2021 +0800 Migration: Add webpack@5 hoisting instructions commit 310f9e62570b346a346dae5ca381ac6cb416b69d Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Mon Jul 5 11:21:03 2021 +0200 fix: added the missing property commit 16442f0b860c0edffe6b928283ca992f185b3a26 Merge: af6136c7ec 4bd2fc9b06 Author: Bartłomiej Krakowski <48633090+bart-krakowski@users.noreply.github.com> Date: Mon Jul 5 11:06:30 2021 +0200 Merge branch 'next' into colorpalette_transparency_grid commit 0b3ddb6f923fac3428f2305874be189cbad5afbf Author: Oscar Dominguez <dominguez.celada@gmail.com> Date: Mon Jul 5 01:25:40 2021 +0200 ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows commit eb7209624605be71ca4ef8e5337f2947ade671a8 Author: Kai-Wen, Hsiung <kaiwenhsiung@gmail.com> Date: Sun Jul 4 20:12:47 2021 +0800 Add missing space I've found a missing space between "or" and "CSF" of the paragraph "It will look for any stories available either in MDX or CSF and based on the documentation you've added it will display it..." commit 5715718e883f342a2d05ea80ced789161f096603 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Fri Jul 2 21:29:08 2021 +0100 updates the loader docs commit 4bd2fc9b0677190c59e60fd63841294ab88e80c5 Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:47:19 2021 +0800 6.4.0-alpha.11 next.json version file commit b2810dfff663d45b9cfe32cb83c32b5d8bfbeac8 Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:44:22 2021 +0800 Update git head to 6.4.0-alpha.11, update yarn.lock commit 52cc8f0ba8fc0601c38620f7173a47b0fd7d38e2 Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:39:35 2021 +0800 v6.4.0-alpha.11 commit fed66a3387b97b8d07e3dd6aa99d04b99de05f3e Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:30:08 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.11 [ci skip] commit 165a360710cb2678f96bb91def12226ab8488e7a Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:29:53 2021 +0800 6.4.0-alpha.11 changelog commit 2cfdb1778ee8c413c69f32fda474d95cd4a798f4 Merge: a41d60e45f 90f6c79e83 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 3 03:26:21 2021 +0800 Merge pull request #15468 from storybookjs/fix/broken-links Fix misc broken links commit 90f6c79e83d6db2949bb9aad748ee5aed38a199b Author: Michael Shilman <michael@lab80.co> Date: Sat Jul 3 03:25:25 2021 +0800 Fix misc broken links commit a41d60e45f3c952269fab7d4dc57eb9b20d0f6fc Merge: f929ef5ace a676462e7c Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 3 03:18:57 2021 +0800 Merge pull request #15466 from jeshwan/feat/a11y-addon-reverse-label-description-content Addon-a11y: Reverse help and description labels in accordion commit f929ef5ace48188b002fbea4eaaf17af4d1fab30 Merge: 79d10cdd2c 7c0170ae87 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 3 03:07:07 2021 +0800 Merge pull request #15459 from storybookjs/fix/sidebar-toggle-fullscreen UI: Fix sidebar toggle in fullscreen mode commit 79d10cdd2c7dd11f64af1a2d6969baa319dfe77e Merge: 913ae3b80e 5debe71e27 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 3 01:27:48 2021 +0800 Merge pull request #15456 from PiDelport/patch-1 typo(cli): fix error message (yarn → npm) commit 913ae3b80e51d1f00539efe5ba662915a149f8c1 Merge: 5096004a49 477eec56ea Author: Michael Shilman <shilman@users.noreply.github.com> Date: Sat Jul 3 01:26:49 2021 +0800 Merge pull request #15410 from Marklb/marklb/fix-circular-ref-in-module-metadata Angular: Fix circular reference not being handled in moduleMetadata commit a676462e7cadc894bf42d6f309efcd8e7bd2032b Merge: cad1bf7d8d 5096004a49 Author: Jeshwan Khoodeeram <78091708+jeshwan@users.noreply.github.com> Date: Fri Jul 2 18:46:51 2021 +0400 Merge branch 'storybookjs:next' into feat/a11y-addon-reverse-label-description-content commit 5096004a496216330b88290796de259b8c3a63ca Merge: 051a42e62c b7f47e9360 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Fri Jul 2 15:24:30 2021 +0100 Merge pull request #15405 from storybookjs/fix_react_snippets Chore: (Docs snippets) Updates for jsx and tsx support commit cad1bf7d8da7b99cad21c9675c731812bab6bf50 Author: Jeshwan Khoodeeram <jeshwankhoodeeram@gmail.com> Date: Fri Jul 2 18:14:38 2021 +0400 a11y addon: Reverse help and description content in Accordion commit 051a42e62c70c782c8b21b48ec1f6bd37a927c12 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 19:49:03 2021 +0800 6.4.0-alpha.10 next.json version file commit a0943acd6f36cbad3420ee3315934771c55ae3e7 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 19:47:12 2021 +0800 Update git head to 6.4.0-alpha.10, update yarn.lock commit 1b43aa79911d0d9d936571533cbf76c6ecf928b0 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 19:42:20 2021 +0800 v6.4.0-alpha.10 commit 028faaa9ff05c1b9f62a874157fe80ff765c407c Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 19:33:28 2021 +0800 Update root, peer deps, version.ts/json to 6.4.0-alpha.10 [ci skip] commit 8b5109aaa521809eb9061bdfaf49bcd9ae150e47 Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 19:33:14 2021 +0800 6.4.0-alpha.10 changelog commit f0dd576e04d1910c1b5d328de6e1b418bcf66dda Merge: 4eefcdf82d 9e044fc30f Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 2 19:32:27 2021 +0800 Merge pull request #15372 from 7rulnik/default-aggregate-timeout Core: Fix double rebuilds by removing aggregateTimeout commit 4eefcdf82dae1544197df2b095848cfacdae47cc Merge: a0fc009da0 a1d10a5651 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 2 17:19:30 2021 +0800 Merge pull request #15428 from eirslett/fix/multiple-docs-context-in-vite Addon-docs: Cache DocsContext on window to prevent duplication commit a0fc009da023dab7393883c24419ae2cae4188fa Merge: c74836d513 938c398707 Author: Michael Shilman <shilman@users.noreply.github.com> Date: Fri Jul 2 16:42:13 2021 +0800 Merge pull request #15461 from storybookjs/fix/npm-typo CLI: Fix NPM typo commit 938c39870773a844d08e3872646fffbd3eac7b0c Author: Michael Shilman <michael@lab80.co> Date: Fri Jul 2 16:39:25 2021 +0800 CLI: Fix NPM typo commit 7c0170ae876213d11e2e0e5d71802e3ecd17da22 Author: Yann Braga <yannbf@gmail.com> Date: Thu Jul 1 21:40:27 2021 +0200 fix(sidebar): toggle sidebar when in fullscreen mode commit 5debe71e27415059e7de7bb89f8f21cdda3b1283 Author: Pi Delport <pjdelport@gmail.com> Date: Thu Jul 1 17:22:37 2021 +0200 typo(cli): fix error message (yarn → npm) commit a61c50e695aa370cd5899affba63eafb3666387d Merge: 93dc1e9ad6 c74836d513 Author: Nazeeh Vahora <nazeehvahora.786@gmail.com> Date: Thu Jul 1 01:35:22 2021 +0530 Merge branch 'storybookjs:next' into my-first-storybook-contribution commit 93dc1e9ad60e9bf41349823777087967ff10f865 Author: Nazeeh2000 <nazeehvahora.786@gmail.com> Date: Thu Jul 1 01:32:14 2021 +0530 Change background to theme.background.app in Control button, Search and svg Arrows commit a1d10a56519d71fb7a9fc0f3d71cc7a5269eb4d7 Author: Eirik Sletteberg <eiriksletteberg@gmail.com> Date: Wed Jun 30 00:11:28 2021 +0200 Fix: cache DocsContext on window to prevent duplication This is intended to solve storybookjs/builder-vite#40 and related issues. commit 477eec56ea0e866d080f6937fb4be38c7b33d8f6 Author: Mark Berry <markberry867@gmail.com> Date: Tue Jun 29 02:44:35 2021 -0500 Fix circular reference not being handled in moduleMetadata commit b7f47e93601977c3b41e311c06e3241b7af30b15 Author: jonniebigodes <joaocontadesenvolvimento@gmail.com> Date: Mon Jun 28 23:00:33 2021 +0100 updates for jsx and tsx support commit 9e044fc30f99e38a5a9dcfc068a22d54cf8990f2 Author: Valentin Semirulnik <v7rulnik@gmail.com> Date: Fri Jun 25 22:43:57 2021 +0300 fix: remove aggregateTimeout commit d1039bc2e310bc97c0e5a8108227bd0ad80b6eac Author: Benny Powers <web@bennypowers.com> Date: Thu Jun 24 10:25:09 2021 +0300 docs(web-components): kitchen sink dynamic source example commit b66e3b28969604ee28da37ba46b315605b8c4b4a Author: Benny Powers <web@bennypowers.com> Date: Thu Jun 24 09:57:36 2021 +0300 docs(web-components): add web-components to Dynamic Source support table commit e58406238f1cbd4a5fee82e2b572025c4cd5d9ed Author: Benny Powers <web@bennypowers.com> Date: Thu Jun 24 09:45:20 2021 +0300 fix(web-components): types commit fbacf4ec9ec91a5670bef40583f55cbe84552527 Author: Benny Powers <web@bennypowers.com> Date: Thu Jun 24 09:32:20 2021 +0300 style(web-components): refactor to TS Split config functions into separate modules Add type and language to docs.source commit 64efb2676d5ef15b15f346803291730119563140 Author: Benny Powers <web@bennypowers.com> Date: Wed Jun 23 22:43:17 2021 +0300 test(web-components): dynamic stories commit 49f8c41f83371b6c125360124095c44e1834a517 Author: Benny Powers <bennypowers@users.noreply.github.com> Date: Wed Jun 23 21:37:52 2021 +0300 feat(web-components): dynamic source Adds dynamic source to the web-components 'framework' package. commit af6136c7ec90c16c1fff1881fe6f2adc6c60dbb5 Author: Bartłomiej Krakowski <bartlomiej@krakowski.dev> Date: Thu Apr 1 15:32:46 2021 +0200 feat: adding transparency support commit 8042564e613871cf7510a6bd58a1293db1ccc4f9 Author: Matt Darveniza <matt.darveniza@biarri.com> Date: Thu Aug 20 16:43:33 2020 +1000 Add example codesnippet for using ArgsTable with stories commit cdaf6f049f35bfae2b0c725385612a4e650791fd Merge: f7639075ab 9941335bb9 Author: Norbert de Langen <ndelangen@me.com> Date: Thu Jun 4 22:17:21 2020 +0200 Merge branch 'next' into tech/add-docs-to-standalone # Conflicts: # examples/standalone-preview/package.json # examples/standalone-preview/storybook.html # examples/standalone-preview/storybook.tsx commit f7639075ab0ec790807d6733e91a96cc4d590f53 Merge: 8d620614c7 a4622c9041 Author: Norbert de Langen <ndelangen@me.com> Date: Sat Dec 21 15:01:57 2019 +0100 Merge branch 'next-6.0.0' into tech/add-docs-to-standalone # Conflicts: # examples/standalone-preview/package.json commit 8d620614c7aeb790ec7f4aad21844b0f0abbfd91 Author: Michael Shilman <michael@lab80.co> Date: Fri Aug 23 21:27:05 2019 +0800 Addon-docs: Add docs to standalone example
Issue: #11588
Adds dynamic source to the web-components 'framework' package.
What I did
Emit the rendered story html (minus lit-html's placeholder comments) to the source channel.
Questions:
TemplateResult
? If not then what?document
?How to test
👉 long time lurker first time poster. submitting this single-file PR for discussion and to arouse feedback from our good maintainers.