Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: update addon interactions example #16698

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 16, 2021

Issue: N/A

What I did

Added a form example in examples/angular-cli so we can do more complex interactions:

image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added maintenance User-facing maintenance tasks angular labels Nov 16, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 16, 2021

Nx Cloud Report

CI ran the following commands for commit ffe7c3d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Nov 16, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit b8b03f3.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@yannbf
Copy link
Member Author

yannbf commented Nov 16, 2021

Edit: Nevermind, the problem was not my code, it was actually the argTypeEnhancers from addon-docs! Will create a github issue for those

For some reason the code was working great and stopped working even though I changed it back to the state that was working perfectly. I think there's a cache issue going on in SB for angular. Whenever I made changes in the angular component, the values were not updated in Storybook and I had to restart it 🤔

@ThibaudAV could you please help out fix the following issue? Might be easy peasy but I can't figure out why that is happening 😭

ERROR Error: Error trying to diff '['Really Smart', 'Super Flexible', 'Super Hot', 'Weather Changer']'. Only arrays and iterables are allowed

@yannbf yannbf marked this pull request as ready for review November 17, 2021 08:17
@yannbf yannbf force-pushed the chore/update-interaction-example-angular branch from d174582 to ffe7c3d Compare November 17, 2021 08:18
@ghengeveld ghengeveld merged commit 32c7e7f into next Nov 17, 2021
@ghengeveld ghengeveld deleted the chore/update-interaction-example-angular branch November 17, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants