Enable eslint for vue-related stuff #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
commented
Aug 23, 2017
| @@ -87,13 +84,13 @@ export function renderMain(data, storyStore) { | |||
| Use "() => ({ template: '<my-comp></my-comp>' })" or "() => ({ components: MyComp, template: '<my-comp></my-comp>' })" when defining the story. | |||
| `, | |||
| }; | |||
| return renderError(error); | |||
| renderError(error); | |||
There was a problem hiding this comment.
renderError has no return value, so it's safe
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
+ Coverage 21.23% 21.24% +<.01%
==========================================
Files 252 252
Lines 5702 5700 -2
Branches 683 688 +5
==========================================
Hits 1211 1211
Misses 3970 3970
+ Partials 521 519 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eslintignorehad avueline since vue support was WIP. This PR turns eslint on for those folders.