Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview scrolling #1782

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Fix preview scrolling #1782

merged 2 commits into from
Sep 4, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #1779

What I did

Used an overlay div instead of pointer-events: none when dragging.
See tomkp/react-split-pane#30, Chromium bug

How to test

  1. Open cra-kitchen-sink in Chrome
  2. Resize browser window so that it's lower than the preview content
  3. Resize some of the panes (stories / addon)
  4. Try to scroll the preview

@Hypnosphi Hypnosphi changed the base branch from master to release/3.3 August 31, 2017 23:51
@codecov
Copy link

codecov bot commented Aug 31, 2017

Codecov Report

Merging #1782 into release/3.3 will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1782      +/-   ##
===============================================
+ Coverage        23.13%   23.13%   +<.01%     
===============================================
  Files              253      253              
  Lines             5745     5748       +3     
  Branches           685      678       -7     
===============================================
+ Hits              1329     1330       +1     
- Misses            3921     3937      +16     
+ Partials           495      481      -14
Impacted Files Coverage Δ
app/react/src/server/index.html.js 0% <ø> (ø) ⬆️
app/react-native/src/server/index.html.js 0% <ø> (ø) ⬆️
app/vue/src/server/index.html.js 0% <ø> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 76.27% <60%> (-2.31%) ⬇️
lib/ui/src/modules/ui/containers/stories_panel.js 25.71% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.81% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 22.41% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4858c1...eef143a. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ndelangen ndelangen merged commit b4c2f99 into release/3.3 Sep 4, 2017
@ndelangen ndelangen deleted the fix-preview-scrolling branch September 4, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants