Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use actions in sample stories for vue + fix them in SFC_VUE template #1867

Merged
merged 6 commits into from Sep 25, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #1866

Looks like linkTo was used instead of action by mistake

How to test

cd lib/cli/test/snapshots/vue
yarn
yarn storybook

@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #1867 into release/3.3 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1867      +/-   ##
===============================================
- Coverage        22.25%   22.24%   -0.01%     
===============================================
  Files              325      325              
  Lines             6521     6522       +1     
  Branches           816      816              
===============================================
  Hits              1451     1451              
- Misses            4456     4457       +1     
  Partials           614      614
Impacted Files Coverage Δ
lib/cli/test/snapshots/vue/stories/index.js 0% <0%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/vue/src/server/utils.js 53.57% <0%> (+53.57%) ⬆️
app/react/src/server/config/babel.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff95a5...6f4b7eb. Read the comment docs.

@Hypnosphi Hypnosphi added the bug label Sep 22, 2017
@Hypnosphi Hypnosphi changed the title CLI: Use actions in sample stories for vue CLI: Use actions in sample stories for vue + fix them in SFC_VUE template Sep 22, 2017
@ndelangen
Copy link
Member

Merge when ready

@Hypnosphi Hypnosphi merged commit 29ad9af into release/3.3 Sep 25, 2017
@ndelangen ndelangen deleted the vue-cli-actions branch September 25, 2017 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants