Cleanup: Make ESLint the default formatter in vscode #19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
added
the
cleanup
IanVS
changed the title
|
@kasperpeulen I added the setting for eslint that you asked for. 👍 |
kasperpeulen
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
In my vscode global settings, I use prettier as my default format-on-save extension. But, storybook runs prettier through ESLint, and has other rules like
@typescript-eslint/consistent-type-imports(see #19656) which can auto-fix as well.What I did
I configured VSCode to use the ESLint extension to format javascript, typescript, and jsx files on save.
I also enabled deepscan when opening
/codedirectly (to keep the vscode settings in-sync between root and code).How to test
Open either the storybook repo or the
/codedirectory (where I often work out of), introduce a linting error that's auto-fixable, and press save, and formatting should happen.