Tech: bundle @vitejs/plugin-vue in #20343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
IanVS
approved these changes
Dec 29, 2022
| "externals": [ | ||
| "util", | ||
| "tty", | ||
| "path" |
There was a problem hiding this comment.
Why do these need to be listed as externals now?
There was a problem hiding this comment.
Good question.. I do not remember 2 weeks later..
I think something relating to the package being bundled in using this, but them being node-internals?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: vitejs/plugin-vue has an exact dep on vite4, when we try to make it vite3 compatible. It IS actually compatible, but the version range said it is not.
What I did
I bundled the package in, therefore the dependency disappears and can also not give a unsatisfied peerDependency warning in pnpm