Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to new favicon #2113

Merged
merged 1 commit into from Oct 23, 2017
Merged

Updating to new favicon #2113

merged 1 commit into from Oct 23, 2017

Conversation

design1online
Copy link

Issue: #2104 - Update React app favicon

What I did

Updated .ico files to a new version of the Storybook logo

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #2113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2113   +/-   ##
=======================================
  Coverage   21.41%   21.41%           
=======================================
  Files         263      263           
  Lines        5796     5796           
  Branches      696      701    +5     
=======================================
  Hits         1241     1241           
+ Misses       4016     4010    -6     
- Partials      539      545    +6
Impacted Files Coverage Δ
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.7% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e47679...171da12. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @design1online !

@ndelangen ndelangen merged commit 5ec2e7c into storybookjs:master Oct 23, 2017
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 23, 2017
@Hypnosphi
Copy link
Member

Looks like it became really small when comparing to the previous one. Can we remove the margins?
screen shot 2017-10-23 at 14 18 54

@ndelangen
Copy link
Member

Yes, if we can reduce the margins that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants