Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember: Fix broken import #21580

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions app/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"prepare": "node ../../scripts/prepare.js"
},
"dependencies": {
"@storybook/addons": "6.5.16",
"@storybook/core": "6.5.16",
"@storybook/core-common": "6.5.16",
"@storybook/docs-tools": "6.5.16",
Expand Down
1 change: 0 additions & 1 deletion app/ember/src/client/docs/jsondoc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const extractArgTypes = (componentName) => {
return componentDoc.attributes.arguments.reduce((acc, prop) => {
acc[prop.name] = {
name: prop.name,
defaultValue: prop.defaultValue,
description: prop.description,
table: {
defaultValue: { summary: prop.defaultValue },
Expand Down
1 change: 0 additions & 1 deletion app/ember/src/client/preview/docs/jsondoc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const extractArgTypes = (componentName) => {
return componentDoc.attributes.arguments.reduce((acc, prop) => {
acc[prop.name] = {
name: prop.name,
defaultValue: prop.defaultValue,
description: prop.description,
table: {
defaultValue: { summary: prop.defaultValue },
Expand Down
37 changes: 29 additions & 8 deletions app/ember/src/client/preview/index.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,37 @@
import { start } from '@storybook/core';
import { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
import { renderToDOM } from './render';
import { EmberFramework, IStorybookSection } from './types';

const { configure: coreConfigure, clientApi, forceReRender } = start(renderToDOM);
const framework = 'ember';

export const { setAddon, addDecorator, addParameters, clearDecorators, getStorybook, raw } =
clientApi;
interface ClientApi extends ClientStoryApi<EmberFramework['storyResult']> {
setAddon(addon: any): void;
configure(loader: Loadable, module: NodeModule): void;
getStorybook(): IStorybookSection[];
clearDecorators(): void;
forceReRender(): void;
raw: () => any; // todo add type
load: (...args: any[]) => void;
}

const framework = 'ember';
export const storiesOf = (kind: string, m: any) =>
clientApi.storiesOf(kind, m).addParameters({ framework });
export const configure = (loadable: any, m: any) => coreConfigure(framework, loadable, m);
const api = start(renderToDOM);

export const storiesOf: ClientApi['storiesOf'] = (kind, m) => {
return (api.clientApi.storiesOf(kind, m) as ReturnType<ClientApi['storiesOf']>).addParameters({
framework,
});
};

export { forceReRender };
export const configure: ClientApi['configure'] = (...args) => api.configure(framework, ...args);
export const addDecorator: ClientApi['addDecorator'] = api.clientApi
.addDecorator as ClientApi['addDecorator'];
export const addParameters: ClientApi['addParameters'] = api.clientApi
.addParameters as ClientApi['addParameters'];
export const clearDecorators: ClientApi['clearDecorators'] = api.clientApi.clearDecorators;
export const setAddon: ClientApi['setAddon'] = api.clientApi.setAddon;
export const forceReRender: ClientApi['forceReRender'] = api.forceReRender;
export const getStorybook: ClientApi['getStorybook'] = api.clientApi.getStorybook;
export const raw: ClientApi['raw'] = api.clientApi.raw;
10 changes: 10 additions & 0 deletions app/ember/src/client/preview/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,13 @@ export type EmberFramework = {
component: any;
storyResult: OptionsArgs;
};

export interface IStorybookStory {
name: string;
render: (context: any) => any;
}

export interface IStorybookSection {
kind: string;
stories: IStorybookStory[];
}
2 changes: 1 addition & 1 deletion examples/ember-cli/app/app.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Application from '@ember/application';
import loadInitializers from 'ember-load-initializers';
import Resolver from './resolver';
import Resolver from 'ember-resolver';
import config from './config/environment';

const App = Application.extend({
Expand Down
1 change: 0 additions & 1 deletion examples/ember-cli/app/resolver.js

This file was deleted.

9 changes: 9 additions & 0 deletions examples/ember-cli/config/ember-try.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');

module.exports = async function () {
return {
scenarios: [embroiderSafe(), embroiderOptimized()],
};
};
2 changes: 1 addition & 1 deletion examples/ember-cli/config/targets.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
browsers: ['ie 9', 'last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'],
browsers: ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'],
};
6 changes: 3 additions & 3 deletions examples/ember-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,21 @@
"ember-cli": "~3.24.0",
"ember-cli-app-version": "^4.0.0",
"ember-cli-babel": "^7.23.0",
"ember-cli-htmlbars": "^4.4.0",
"ember-cli-htmlbars": "^5.3.1",
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-shims": "^1.2.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-uglify": "^3.0.0",
"ember-load-initializers": "^2.1.2",
"ember-resolver": "^7.0.0",
"ember-resolver": "^8.0.2",
"ember-source": "~3.24.0",
"loader.js": "^4.7.0",
"shx": "^0.3.2",
"webpack": "4",
"webpack-cli": "^4.2.0"
},
"engines": {
"node": "^4.5 || 6.* || >= 7.*"
"node": "10.* || >= 12"
},
"storybook": {
"chromatic": {
Expand Down