#1750 CRA Example cleanup - knobs and notes #2177
Conversation
danielduan
added
cleanup
| </WithNotes> | ||
| )); | ||
|
|
||
| storiesOf('component.base.Link', module) |
There was a problem hiding this comment.
I got rid of these because they don't seem to be testing or documenting anything in particular. Seems like a waste of space and code to me.
There was a problem hiding this comment.
I think they are for testing deep nesting of stories
There was a problem hiding this comment.
I think in this case it should be okay to delete. The examples for Addon Info are pretty well nested too.
There was a problem hiding this comment.
Yeah, it was added for the hierarchy feature. If other examples are descriptive enough to demonstrate the hierarchy, it's ok to delete all of these.
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
=======================================
Coverage 21.43% 21.43%
=======================================
Files 263 263
Lines 5803 5803
Branches 698 686 -12
=======================================
Hits 1244 1244
- Misses 4029 4047 +18
+ Partials 530 512 -18
Continue to review full report at Codecov.
|
| </WithNotes> | ||
| )); | ||
|
|
||
| storiesOf('component.base.Link', module) |
There was a problem hiding this comment.
Yeah, it was added for the hierarchy feature. If other examples are descriptive enough to demonstrate the hierarchy, it's ok to delete all of these.
Issue:
#1750 example app too messy
What I did
reorganized knobs and notes
How to test
Is this testable with jest or storyshots?
yes
Does this need a new example in the kitchen sink apps?
yes
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.