Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2081 fix hmr in react-native template #2194

Merged
merged 4 commits into from Nov 1, 2017
Merged

#2081 fix hmr in react-native template #2194

merged 4 commits into from Nov 1, 2017

Conversation

danielduan
Copy link
Member

Issue:

#2081 react-native hot module reload does not support stateless functional components

What I did

Converted root component to a Class

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2194 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2194   +/-   ##
=======================================
  Coverage   21.42%   21.42%           
=======================================
  Files         263      263           
  Lines        5805     5805           
  Branches      686      694    +8     
=======================================
  Hits         1244     1244           
+ Misses       4048     4025   -23     
- Partials      513      536   +23
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c29d7...ea5276f. Read the comment docs.

@Hypnosphi Hypnosphi self-assigned this Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants