Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Migrate @storybook/preset-create-react-app to strict TS #22395

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Maintenance: Migrate @storybook/preset-create-react-app to strict TS #22395

merged 16 commits into from
Nov 27, 2023

Conversation

kuriacka
Copy link
Contributor

@kuriacka kuriacka commented May 4, 2023 •
edited by ndelangen
Loading

Issue #22176

What I did

Migrate @storybook/create-react-app to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kuriacka kuriacka changed the title Migrate @storybook/create-react-app to strict TS Migrate @storybook/preset-create-react-app to strict TS May 4, 2023
@kuriacka kuriacka marked this pull request as ready for review May 4, 2023 10:56
@kasperpeulen kasperpeulen self-requested a review May 31, 2023 09:32
kasperpeulen
kasperpeulen requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one thing that confuses me!

code/presets/create-react-app/src/index.ts Outdated Show resolved Hide resolved
kasperpeulen
kasperpeulen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:pr labels Jun 19, 2023
@kasperpeulen kasperpeulen changed the title Migrate @storybook/preset-create-react-app to strict TS Maintenance: Migrate @storybook/preset-create-react-app to strict TS Jun 19, 2023
@valentinpalkovic valentinpalkovic removed their request for review October 2, 2023 12:41
@ndelangen ndelangen self-assigned this Oct 3, 2023
@ndelangen ndelangen removed their assignment Nov 24, 2023
@ndelangen ndelangen changed the title Maintenance: Migrate @storybook/preset-create-react-app to strict TS Maintenance: Migrate @storybook/preset-create-react-app to strict TS Nov 24, 2023
@ndelangen
Copy link
Member

@kuriacka could you check the CI, and fix any remaining issues?

@kuriacka
Copy link
Contributor Author

@kuriacka could you check the CI, and fix any remaining issues?

@ndelangen Sure, I created this PR a while ago, but I will do my best.

@ndelangen ndelangen changed the base branch from next to release-8-0 November 27, 2023 12:35
@ndelangen ndelangen merged commit 904b9ee into storybookjs:release-8-0 Nov 27, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees

@kasperpeulen kasperpeulen

Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuriacka @ndelangen @kasperpeulen @valentinpalkovic