Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Add addon-onboarding as part of init #22972

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 8, 2023

closes #22872, closes #22870

What I did

This PR adds @storybook/addon-onboarding as part of the initiate step and execute dev with --initial-path=/onboarding to the CLI of (for now) React projects

This should not be merged until the addon-onboarding is ready.

How to test

  1. Build all packages
  2. Create a new project with the CLI e.g. ./code/lib/cli/bin/index.js init
  3. Expect Storybook to open with the onboarding flow

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf self-assigned this Jun 12, 2023
Base automatically changed from feat/initial-paths-cli-flag to next June 13, 2023 07:54
@valentinpalkovic valentinpalkovic merged commit dd7032b into next Jun 22, 2023
55 of 56 checks passed
@valentinpalkovic valentinpalkovic deleted the feat/addon-onboarding branch June 22, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment