Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Improve DangerJS workflow #23001

Merged
merged 1 commit into from
Jun 9, 2023
Merged

CI: Improve DangerJS workflow #23001

merged 1 commit into from
Jun 9, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jun 9, 2023 •
edited
Loading

What I did

Changed the DangerJS workflow to:

  1. only run on PRs to next and main
  2. Make it cancel any previous runs if there are any currently running.

We got rate limitted because we ran Danger 50 times in a row because I ticked off a lot of checkboxes in a PR description. 😅

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold requested a review from a team as a code owner June 9, 2023 11:51
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Jun 9, 2023
@JReinhold JReinhold changed the title CI: Improve danger workflow CI: Improve DangerJS workflow Jun 9, 2023
@JReinhold JReinhold merged commit 9bd8aa4 into next Jun 9, 2023
34 of 42 checks passed
@JReinhold JReinhold deleted the improve-danger branch June 9, 2023 12:05
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JReinhold @ndelangen