Mdx : Theme fontCode not applied consistently when writing MDX
#23110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitstart-storybook
changed the title
fontCode not applied consistently when writing MDXfontCode not applied consistently when writing MDX
gitstart-storybook
changed the title
fontCode not applied consistently when writing MDXfontCode not applied consistently when writing MDX
ndelangen
reviewed
Jun 21, 2023
Comment on lines
+129
to
140
| return ( | ||
| <ThemeProvider | ||
| theme={convert({ | ||
| ...overrideTheme, | ||
| fontCode: typography.fonts.mono, | ||
| fontBase: typography.fonts.base, | ||
| })} | ||
| > | ||
| {syntaxHighlighter} | ||
| </ThemeProvider> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Can you explain why this is required? I'd assume the fix code/ui/components/src/syntaxhighlighter/syntaxhighlighter.tsx would be enough on it's own?
There was a problem hiding this comment.
Thanks @ndelangen for the review. We have passed the content of code from here
which is not actually the Code defined over here
So fix over code/ui/components/src/syntaxhighlighter/syntaxhighlighter.tsx is not enough.
ndelangen
approved these changes
Jul 10, 2023
ndelangen
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #21804
What I did
fontFamily: theme.typography.fonts.monoto fix the issue oftypography.fonts.monoto use the user defined fontCode in order to fix the issue related toSourceHow to test
fontCodenot applied consistently when writing MDX #21804Ref
GitStart Ticket
Demo