Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxHighlighter: Expose registerLanguage #23166

Merged
merged 14 commits into from
Jul 5, 2023
Merged

SyntaxHighlighter: Expose registerLanguage #23166

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6e83efb
experiment with exposing registerLanguage
ndelangen Jun 21, 2023
d038135
Merge branch 'next' into norbert/fix-21341
ndelangen Jun 22, 2023
711f2ea
portal the registerLanguage api through the lazy component
ndelangen Jun 22, 2023
9520625
Merge branch 'next' into norbert/fix-21341
ndelangen Jun 27, 2023
7a7eef0
register SyntaxHighlighter languages without formatter
hobbes7878 Jun 27, 2023
3975d93
remove unneeded typecast
hobbes7878 Jun 27, 2023
602a01a
Revert "remove unneeded typecast"
hobbes7878 Jun 27, 2023
d4a115d
recast StyledSyntaxHighlighter type in Source component
hobbes7878 Jun 29, 2023
d4a749c
Merge branch 'next' into norbert/fix-21341
hobbes7878 Jun 29, 2023
caff290
adds story demonstrating custom language syntax added to highlighter
hobbes7878 Jul 5, 2023
a599ade
Merge branch 'norbert/fix-21341' of https://github.com/storybookjs/st…
hobbes7878 Jul 5, 2023
a9d0d22
register custom syntax in a story loader
hobbes7878 Jul 5, 2023
5bf47dd
Merge branch 'next' into norbert/fix-21341
hobbes7878 Jul 5, 2023
d1c157e
move import of custom syntax into story loader
hobbes7878 Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 18 additions & 1 deletion code/ui/components/src/syntaxhighlighter/syntaxhighlighter.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import { ThemeProvider, ensure, themes } from '@storybook/theming';

import type { ComponentProps } from 'react';
import React from 'react';
import { ThemeProvider, themes, ensure } from '@storybook/theming';
import scss from 'react-syntax-highlighter/dist/esm/languages/prism/scss';
ndelangen marked this conversation as resolved.
Show resolved Hide resolved
import { SyntaxHighlighter } from './lazy-syntaxhighlighter';

// Register custom language
SyntaxHighlighter.registerLanguage('scss', scss);
Copy link
Member Author

@ndelangen ndelangen Jul 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be done, as the story renders, a custom render function would allow us to do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. Let me try that. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realize I'm reading too quickly and did this in a custom loader instead of render func in a9d0d22. The loader works, but let me know if you'd prefer I go the render route. Happy to rewrite.


export default {
component: SyntaxHighlighter,
};
Expand Down Expand Up @@ -108,6 +113,18 @@ export const GraphQL = {
},
};

export const CustomSyntax = {
args: {
language: 'scss',
children: `// Custom language syntax registered
div.parent {
div.child {
color: $red;
}
}`,
},
};

export const Unsupported = {
args: {
language: 'C#',
Expand Down